-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downgrade logic for branch in DocLinkService #3483
Merged
abbyhu2000
merged 14 commits into
opensearch-project:main
from
SuZhou-Joe:feature/patch_branch_when_build
Mar 23, 2023
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9df87a5
feature: patch pkg.branch when needed
SuZhou-Joe f533c75
feat: update CHANGELOG.md
SuZhou-Joe 730d694
feat: use buildVersion
SuZhou-Joe b09c3eb
Update src/dev/build/tasks/create_package_json_task.ts
SuZhou-Joe 8f8521d
feat: pass ts type check
SuZhou-Joe 59897b0
feat: move branch logic to runtime to restrict impact
SuZhou-Joe 361eaf5
feat: update changelog
SuZhou-Joe a6c1f8a
Revert "feat: pass ts type check"
SuZhou-Joe 6f97098
Revert "Update src/dev/build/tasks/create_package_json_task.ts
"
SuZhou-Joe 1dff042
Revert "feat: use buildVersion"
SuZhou-Joe 35fff82
Revert "feature: patch pkg.branch when needed"
SuZhou-Joe 20c04b0
feat: remove error message and update unit test
SuZhou-Joe 2a698e3
feat: add default value
SuZhou-Joe f0d6198
feat: optimize code logic
SuZhou-Joe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this prevent the builds if they pass a non-valid doc paths pattern in the branch in the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if no version can be specified after so many downgrade logic, we will prevent the build because there will be a doc link error if we continue to build.