-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump node.js from v14.21.3 to v18.15.0 #3608
Conversation
8e16947
to
d0f49c6
Compare
e79062d
to
daedc87
Compare
Revert "add node fiber to improve performance (opensearch-project#2319)" Revert "[CVE-2022-25758] Use dart-sass instead of node-sass (opensearch-project#2054)" Revert back to use node-sass and bump to 8.0.0 Change lmdb-store to lmdb Bump node.js to 18 and fix errors Issue Resolved: opensearch-project#3601 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
daedc87
to
ca60f16
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3608 +/- ##
==========================================
- Coverage 66.44% 66.29% -0.15%
==========================================
Files 3227 3227
Lines 62051 62064 +13
Branches 9593 9599 +6
==========================================
- Hits 41227 41143 -84
- Misses 18523 18602 +79
- Partials 2301 2319 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 27 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@joshuarrrr thanks. since we decides to use patched webpack in #4071, close this PR. |
Description
Revert "add node fiber to improve performance (#2319)"
Revert "[CVE-2022-25758] Use dart-sass instead of node-sass (#2054)"
Revert back to use node-sass and bump to 8.0.0
Change lmdb-store to lmdb
Bump node.js to 18 and fix errors
Issues Resolved
#3601
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr