Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Use mirrors to download Node.js binaries to escape sporadic 404 errors #3664

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 99a88e3 from #3619.

#3619)

Issue Resolved:
#3618

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
(cherry picked from commit 99a88e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 23, 2023 01:02
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Merging #3664 (da5bccb) into 2.x (a7fd42c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.x    #3664   +/-   ##
=======================================
  Coverage   66.45%   66.45%           
=======================================
  Files        3208     3208           
  Lines       61593    61593           
  Branches     9502     9502           
=======================================
+ Hits        40932    40934    +2     
+ Misses      18384    18383    -1     
+ Partials     2277     2276    -1     
Flag Coverage Δ
Linux 66.40% <100.00%> (+<0.01%) ⬆️
Windows 66.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dev/build/tasks/nodejs/node_download_info.ts 88.88% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abbyhu2000 abbyhu2000 added the autocut Skip the changelog verification check on backports label Mar 23, 2023
@joshuarrrr
Copy link
Member

failed whitesource check can be ignored.

@abbyhu2000 abbyhu2000 merged commit 36f64cd into 2.x Mar 24, 2023
@github-actions github-actions bot deleted the backport/backport-3619-to-2.x branch March 24, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants