-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delimiter for list of values #3686
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3686 +/- ##
==========================================
+ Coverage 66.38% 66.43% +0.04%
==========================================
Files 3210 3210
Lines 61676 61676
Branches 9522 9522
==========================================
+ Hits 40942 40972 +30
+ Misses 18448 18422 -26
+ Partials 2286 2282 -4
Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>
@sayuree For this PR, it would be helpful to add a screencast or multiple screenshots of what it's like to use the new field to add multiple filters. |
This is not a complete fix for the issue (see opensearch-project/oui#661). But it is a step in the right direction. |
@sayuree All tests pass, and the change looks good. Just a couple small changes requested for the CHANGELOG, then we can approve. |
Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>
All tests passed |
* Add delimiter * Edit CHANGELOG.md Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> --------- Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit be47d9a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* Add delimiter for list of values (#3686) * Add delimiter * Edit CHANGELOG.md Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> --------- Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit be47d9a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md * add changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <rmerqg@amazon.com>
* Add delimiter * Edit CHANGELOG.md Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> --------- Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz> Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
Description
[Added delimiter for values in Add filter]
Issues Resolved
partially opensearch-project/oui#661
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr