Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix error message display issue in dev tool console #3699

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 53047b6 from #3652.

Fix error message display issue in dev tool console

When user sends request in the console and result in error, the console will output a customized error message.

Signed-off-by: Su <szhongna@amazon.com>
(cherry picked from commit 53047b6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 27, 2023 17:47
@joshuarrrr joshuarrrr added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.7.0 labels Mar 27, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3699 (9230835) into 2.x (e3a5a2a) will decrease coverage by 0.06%.
The diff coverage is 40.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3699      +/-   ##
==========================================
- Coverage   66.46%   66.41%   -0.06%     
==========================================
  Files        3209     3209              
  Lines       61610    61610              
  Branches     9505     9504       -1     
==========================================
- Hits        40951    40916      -35     
- Misses      18382    18412      +30     
- Partials     2277     2282       +5     
Flag Coverage Δ
Linux 66.41% <40.00%> (-0.01%) ⬇️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../server/routes/api/console/proxy/create_handler.ts 74.35% <25.00%> (-2.57%) ⬇️
src/core/server/opensearch/client/errors.ts 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abbyhu2000 abbyhu2000 merged commit 613f9c2 into 2.x Mar 27, 2023
@github-actions github-actions bot deleted the backport/backport-3652-to-2.x branch March 27, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants