Add an achievement badger to the PR #3721
Conversation
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
| permissions: | ||
| pull-requests: write | ||
| steps: | ||
| - uses: aws-github-ops/github-merit-badger@v0.0.98 |
There was a problem hiding this comment.
does this need to be allowed for the org?
i know in the past if the github action was not explicitly defined at the org wide settings that it will fail (at least for write permissions)
There was a problem hiding this comment.
Its the same as the one thats already applied to OpenSearch and opensearch-build repos. They already have this in place and are using it. so i think its safe to assume that it will work
CHANGELOG.md
Outdated
| @@ -123,6 +123,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Fix detection of Chrome's version on Darwin during CI ([#3296](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3296)) | |||
| - Upgrade yarn version to be compatible with @openearch-project/opensearch ([#3443](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3443)) | |||
| - [CI] Reduce redundancy by using matrix strategy on Windows and Linux workflows ([#3514](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3514)) | |||
| - Adds achievement workflow ([#3721](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3721)) | |||
There was a problem hiding this comment.
| - Adds achievement workflow ([#3721](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3721)) | |
| - Add an achievement badger to the PR workflow ([#3721](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3721)) |
ashwin-pc
changed the title
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3721 +/- ##
==========================================
- Coverage 66.45% 66.44% -0.01%
==========================================
Files 3209 3209
Lines 61633 61633
Branches 9506 9506
==========================================
- Hits 40960 40954 -6
- Misses 18396 18400 +4
- Partials 2277 2279 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* Adds achievement workflow Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Adds changelog entry Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update CHANGELOG.md based on suggestion --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: vagimeli <vagimeli@amazon.com>
* Adds achievement workflow Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Adds changelog entry Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update CHANGELOG.md based on suggestion --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
Description
Adding the achievement workflow for PR's
Issues Resolved
#3708
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr