[CVE-2021-3803][1.x] Bump nth-check from 1.0.2 to 2.0.1 #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
added
cve
Issue Resolve opensearch-project#1081 Backport PR opensearch-project#1422 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
force-pushed
the
1.x-bump-nth-check
branch
from
9ff90f0 to
6d0af4f
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 1.x #3729 +/- ##
=======================================
Coverage 67.49% 67.50%
=======================================
Files 3044 3044
Lines 58692 58692
Branches 8902 8902
=======================================
+ Hits 39617 39619 +2
+ Misses 16926 16925 -1
+ Partials 2149 2148 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Yeah, https://github.com/fb55/nth-check/releases/tag/v2.0.0 also seems like relatively safe breaking changes |
|
WhiteSource check failure can be ignored. |
joshuarrrr
approved these changes
Mar 30, 2023
abbyhu2000
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nth-checkis @v1.0.2 and we needs @v2.0.1 to fix the CVE.Main is bumped via PR here. As mentioned in the PR:
nth-check is a dependency of cheerio > css-select. Even though our dependency on cheerio@0.22.0 pulls in nth-check@~1.0.1, its signature hasn't changed* in nth-check@2.0.1 and a resolution to bump works. (*) The signature has changed but is backward compatible.Double checked and don't see breaking changes here. Therefore, we should backport this PR.
Issue Resolve
#1081
Backport PR
#1422
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr