[CCI] Add new or remove extra tags and styles in saved_objects_management plugin

[SergeyMyssak]

Description

Added new or removed extra tags and styles in saved_objects_management plugin

Issues Resolved

#3967

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[SergeyMyssak]

<span></span> tags are redundant and can be replaced with <></>

[joshuarrrr]

Do we even need the <></>? The entire return object is wrapped in <Fragment> already.

[ananzh]

+1

[SergeyMyssak]

I reduced the number of Fragment, also I unintentionally overwrote @joshuarrrr merge commit, I apologize 😨

[codecov]

Codecov Report

Merging #4069 (dd5f710) into main (e07c5e6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4069   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files        3244     3244           
  Lines       62470    62470           
  Branches     9713     9713           
=======================================
  Hits        41475    41475           
  Misses      18636    18636           
  Partials     2359     2359           

Flag	Coverage Δ
Linux	66.33% <100.00%> (ø)
Windows	66.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...anagement_section/object_view/components/intro.tsx	100.00% <ø> (ø)
...ection/object_view/components/not_found_errors.tsx	100.00% <ø> (ø)
...section/objects_table/components/relationships.tsx	52.17% <ø> (ø)
...gement_section/objects_table/components/flyout.tsx	71.03% <100.00%> (ø)

[SergeyMyssak]

<div></div> should be replaced with <p></p>, in order to indicate a paragraph of text

[SergeyMyssak]

<div></div> should be replaced with <p></p>, in order to indicate a paragraph of text

[ashwin-pc]

Thanks for the change @SergeyMyssak This looks good :) can you resolve the changelog conflicts here?

[joshuarrrr]

@SergeyMyssak Looks great! One minor question about where we may be able to simplify even further, to minimize <></>. BTW, in general, we prefer <> to <Fragment>.

[joshuarrrr]

Do we even need the <></>? The entire return object is wrapped in <Fragment> already.

[joshuarrrr]

Did the linter prefer this formatting? I think the conditionals are more readable when the output is grouped:

Suggested change

	{legacyFileWarning && <EuiSpacer size="s" />}
	{legacyFileWarning}
	{indexPatternConflictsWarning && <EuiSpacer size="s" />}
	{indexPatternConflictsWarning}
	{legacyFileWarning && (
	<EuiSpacer size="s" />
	{legacyFileWarning}
	)}
	{indexPatternConflictsWarning && (
	<EuiSpacer size="s" />
	{indexPatternConflictsWarning}
	)}

[SergeyMyssak]

@joshuarrrr, we can't write it that way, to write it that way we have to wrap the two components in <></>:

{legacyFileWarning && (
  <>
    <EuiSpacer size="s" />
    {legacyFileWarning}
  </>
)}

[joshuarrrr]

Yeah, I think I prefer that, although this whole thing could probably be refactored to be a bit cleaner. I'm OK with either option for now.