Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] New management overview page and rename stack management to dashboard management #4528

Merged

Conversation

Hailong-am
Copy link
Collaborator

Backport d8f0c48 from #4287.

… management (opensearch-project#4287)

Support navigation changes for administrative features. This change includes
* Rename stack management to Dashboard management
* Add new management overview page
* Replace Stack Management to Management overview page on home app categories page
* Make home plugin optional for managemnet overview

Issue Resolved:
opensearch-project#4132

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit d8f0c48)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am marked this pull request as ready for review July 9, 2023 00:39
@Hailong-am Hailong-am changed the title [Backport 2.x] New management overview page and rename stack management to dashboard… [Manual] [Backport 2.x] New management overview page and rename stack management to dashboard… Jul 9, 2023
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #4528 (4d4b64e) into 2.x (a287203) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              2.x    #4528   +/-   ##
=======================================
  Coverage   66.44%   66.44%           
=======================================
  Files        3287     3288    +1     
  Lines       63286    63288    +2     
  Branches     9846     9846           
=======================================
+ Hits        42049    42051    +2     
  Misses      18857    18857           
  Partials     2380     2380           
Flag Coverage Δ
Linux 66.39% <100.00%> (+<0.01%) ⬆️
Windows 66.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/advanced_settings/public/plugin.ts 20.00% <ø> (ø)
...source_management/public/components/breadcrumbs.ts 100.00% <ø> (ø)
.../plugins/index_pattern_management/public/plugin.ts 10.00% <ø> (ø)
...nagement/public/components/management_sections.tsx 100.00% <ø> (ø)
src/plugins/management/public/utils/breadcrumbs.ts 100.00% <ø> (ø)
.../plugins/saved_objects_management/public/plugin.ts 65.00% <ø> (ø)
.../public/components/overview_card/overview_card.tsx 100.00% <100.00%> (ø)

@Hailong-am
Copy link
Collaborator Author

@ashwin-pc @manasvinibs @ananzh Auto backport failed, i have create this manual backport, please help to review, thanks!

@@ -16,6 +16,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Add category option within groups for context menus ([#4144](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4144))
- [Saved Object Service] Add Repository Factory Provider ([#4149](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4149))
- Enable plugins to augment visualizations with additional data and context ([#4361](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4361))
- New management overview page and rename stack management to dashboard management ([#4287](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4287))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the PR number to be the backport one (4528) or keep using the original one is good enough ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autocut PR's anyway skip the change log entry and even though manual backport ones has the opportunity to update the PR number in the change log, I see most of the existing ones in 2.x pointing to the original PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Original PR stands as it has the most accurate history.

@manasvinibs manasvinibs merged commit 3b9d45f into opensearch-project:2.x Jul 10, 2023
@ashwin-pc ashwin-pc changed the title [Manual] [Backport 2.x] New management overview page and rename stack management to dashboard… [Manual Backport 2.x] New management overview page and rename stack management to dashboard management Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants