-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.9] Fix line to vega conversion bug #4558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-trigger-bot
bot
requested review from
ananzh and
kavilla
as code owners
July 12, 2023 20:51
opensearch-trigger-bot
bot
added
the
autocut
Skip the changelog verification check on backports
label
Jul 12, 2023
opensearch-trigger-bot
bot
added
the
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
label
Jul 12, 2023
opensearch-trigger-bot
bot
requested review from
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
July 12, 2023 20:51
Codecov Report
@@ Coverage Diff @@
## 2.9 #4558 +/- ##
=======================================
Coverage 66.16% 66.16%
=======================================
Files 3315 3315
Lines 63887 63887
Branches 9963 9963
=======================================
Hits 42274 42274
Misses 19170 19170
Partials 2443 2443
Flags with carried forward coverage won't be shown. Click here to find out more. |
lezzago
approved these changes
Jul 12, 2023
* Fix line to vega conversion bug Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Update CHANGELOG and release notes Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Address comments Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Add more details to comment Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Not a released changed, so no need to document Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit b94a62f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
lezzago
force-pushed
the
backport/backport-4554-to-2.9
branch
from
July 12, 2023 22:00
cbc5bed
to
60231fd
Compare
lezzago
approved these changes
Jul 12, 2023
ohltyler
approved these changes
Jul 12, 2023
amsiglan
approved these changes
Jul 12, 2023
ashwin-pc
approved these changes
Jul 12, 2023
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autocut
Skip the changelog verification check on backports
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
valued-contributor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b94a62f from #4554.