Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Console] Converted all /lib/autocomplete/**/*.js files to typescript #4620

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d94d7cb from #4148.

…script (#4148)

Major changes are:
* Convert autocomplete part to TS
* reafactor and improve typing
* clean comments for compileBodyDescription
* refactor getTemplate

---------

Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit d94d7cb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot added technical debt If not paid, jeapardizes long-term success and maintainability of the repository. autocut Skip the changelog verification check on backports labels Jul 25, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot added OSCI Open Source Contributor Initiative repeat-contributor v2.10.0 labels Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #4620 (8df8220) into 2.x (57d7ce8) will decrease coverage by 0.06%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##              2.x    #4620      +/-   ##
==========================================
- Coverage   66.19%   66.14%   -0.06%     
==========================================
  Files        3315     3316       +1     
  Lines       63892    63905      +13     
  Branches     9969    10088     +119     
==========================================
- Hits        42295    42267      -28     
- Misses      19156    19164       +8     
- Partials     2441     2474      +33     
Flag Coverage Δ
Linux_1 34.76% <ø> (+0.01%) ⬆️
Linux_2 55.07% <ø> (ø)
Linux_3 ?
Linux_4 ?
Windows_1 34.82% <ø> (ø)
Windows_2 55.03% <ø> (ø)
Windows_3 43.14% <81.81%> (-0.09%) ⬇️
Windows_4 35.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/lib/autocomplete/components/conditional_proxy.ts 66.66% <ø> (ø)
...omplete/components/field_autocomplete_component.ts 44.44% <ø> (ø)
.../autocomplete/components/full_request_component.ts 0.00% <ø> (ø)
...b/autocomplete/components/global_only_component.ts 100.00% <ø> (ø)
...tocomplete/components/id_autocomplete_component.ts 0.00% <0.00%> (ø)
...omplete/components/index_autocomplete_component.ts 100.00% <ø> (ø)
...lete/components/template_autocomplete_component.ts 0.00% <ø> (ø)
...complete/components/type_autocomplete_component.ts 100.00% <ø> (ø)
...lete/components/username_autocomplete_component.ts 0.00% <ø> (ø)
...tocomplete/components/accept_endpoint_component.ts 78.57% <66.66%> (ø)
... and 11 more

... and 3 files with indirect coverage changes

@joshuarrrr joshuarrrr merged commit e25413e into 2.x Jul 25, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-4148-to-2.x branch July 25, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports OSCI Open Source Contributor Initiative repeat-contributor technical debt If not paid, jeapardizes long-term success and maintainability of the repository. v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants