-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OUI to 1.3.0-beta.2 #4848
Merged
ashwin-pc
merged 2 commits into
opensearch-project:main
from
joshuarrrr:chore/bump-oui-1.3.0-beta.2
Aug 30, 2023
Merged
Bump OUI to 1.3.0-beta.2 #4848
ashwin-pc
merged 2 commits into
opensearch-project:main
from
joshuarrrr:chore/bump-oui-1.3.0-beta.2
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
August 29, 2023 22:51
joshuarrrr
added
the
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
label
Aug 29, 2023
ashwin-pc
previously approved these changes
Aug 29, 2023
AMoo-Miki
previously approved these changes
Aug 29, 2023
Codecov Report
@@ Coverage Diff @@
## main #4848 +/- ##
=======================================
Coverage 66.30% 66.31%
=======================================
Files 3322 3322
Lines 63933 63933
Branches 10121 10121
=======================================
+ Hits 42393 42394 +1
Misses 19051 19051
+ Partials 2489 2488 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
CollapsibleNav vars now provided via theme import see opensearch-project/oui#968 Signed-off-by: Josh Romero <rmerqg@amazon.com>
ashwin-pc
approved these changes
Aug 30, 2023
abbyhu2000
approved these changes
Aug 30, 2023
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4848-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03ae2bd8b2456238c1889176392b144d43af6c71
# Push it to GitHub
git push --set-upstream origin backport/backport-4848-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
distinguished-contributor
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump OUI to 1.3.0-beta.2
Also add
@opensearch/datemath
dep due to renamingIssues Resolved
Part of preparation for #4584 and opensearch-project/oui#958
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr