Remove examples and other unwanted artifacts from installed dependencies #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
seanneumann,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
post-install-cleanup-unwanted
branch
from
6af2d23 to
7208291
Compare
Codecov Report
@@ Coverage Diff @@
## main #4896 +/- ##
==========================================
- Coverage 66.39% 66.39% -0.01%
==========================================
Files 3397 3397
Lines 64804 64804
Branches 10360 10360
==========================================
- Hits 43028 43026 -2
- Misses 19217 19224 +7
+ Partials 2559 2554 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
So the post install is targeted to be a specific runtime configuration of OpenSearch Dashboards? Or can examples not be outside of a |
Having the unwanted stuff is not only undesirable for releases but also undesirable / dangerous for contributors. |
joshuarrrr
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Cool, I pulled and tried it and it appears to work great.
We could consider a brief explanatory log message (something like "removing example and demo files from depenedencies") as output:
yarn osd bootstrap
yarn run v1.22.19
$ scripts/use_node scripts/osd bootstrap
info [opensearch-dashboards] running yarn
$ scripts/use_node ./preinstall_check
[1/5] Validating package.json...
[2/5] Resolving packages...
warning Resolution field "typescript@4.0.2" is incompatible with requested version "typescript@~4.5.2"
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning "workspace-aggregator-9f9bce3f-24d7-47b2-9651-cfdc201888fc > osd_tp_run_pipeline > @elastic/eui@1.3.0-beta.2" has incorrect peer dependency "typescript@^4.0.5".
warning "@osd/ace > raw-loader@4.0.2" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning "@osd/interpreter > babel-loader@8.2.4" has unmet peer dependency "webpack@>=2".
warning "@osd/interpreter > copy-webpack-plugin@6.4.1" has unmet peer dependency "webpack@^4.37.0 || ^5.0.0".
warning "@osd/interpreter > css-loader@5.2.7" has unmet peer dependency "webpack@^4.27.0 || ^5.0.0".
warning "@osd/ui-framework > @osd/optimizer > @osd/ui-shared-deps > sass-loader@10.4.1-node-sass-9.0.0-libsass-3.6.5" has unmet peer dependency "webpack@^4.36.0 || ^5.0.0".
warning "@osd/interpreter > style-loader@1.3.0" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning "@osd/interpreter > url-loader@2.3.0" has unmet peer dependency "webpack@^4.0.0".
warning "@osd/interpreter > webpack-cli@4.9.2" has unmet peer dependency "webpack@4.x.x || 5.x.x".
warning "@osd/interpreter > webpack-cli > @webpack-cli/configtest@1.1.1" has unmet peer dependency "webpack@4.x.x || 5.x.x".
warning "@osd/ui-framework > @osd/optimizer > clean-webpack-plugin@3.0.0" has unmet peer dependency "webpack@*".
warning "@osd/ui-framework > @osd/optimizer > @osd/ui-shared-deps > compression-webpack-plugin@4.0.1-rc.1" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning "@osd/ui-framework > @osd/optimizer > terser-webpack-plugin@2.3.8" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning "@osd/ui-framework > @osd/optimizer > file-loader@6.2.0" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning "@osd/ui-framework > @osd/optimizer > postcss-loader@4.3.0" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning "@osd/ui-framework > @osd/optimizer > val-loader@2.1.2" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning "@osd/ui-framework > @osd/optimizer > @osd/ui-shared-deps > mini-css-extract-plugin@1.6.2" has unmet peer dependency "webpack@^4.4.0 || ^5.0.0".
warning "workspace-aggregator-9f9bce3f-24d7-47b2-9651-cfdc201888fc > http-aws-es@6.0.1" has unmet peer dependency "aws-sdk@^2.138.0".
warning "workspace-aggregator-9f9bce3f-24d7-47b2-9651-cfdc201888fc > http-aws-es@6.0.1" has incorrect peer dependency "elasticsearch@^15.0.0".
warning "@osd/eslint-import-resolver-opensearch-dashboards > eslint-import-resolver-webpack@0.11.1" has unmet peer dependency "webpack@>=1.11.0".
[5/5] Building fresh packages...
$ scripts/use_node scripts/postinstall
succ yarn.lock analysis completed without any issues
info [@osd/cross-platform] running [osd:bootstrap] script
info [@osd/stylelint-plugin-stylelint] running [osd:bootstrap] script
info [@osd/test-subj-selector] running [osd:bootstrap] script
info [@osd/utility-types] running [osd:bootstrap] script
succ [@osd/test-subj-selector] bootstrap complete
succ [@osd/utility-types] bootstrap complete
succ [@osd/stylelint-plugin-stylelint] bootstrap complete
succ [@osd/cross-platform] bootstrap complete
info [@osd/config-schema] running [osd:bootstrap] script
info [@osd/std] running [osd:bootstrap] build targets
succ [@osd/std] bootstrap complete
succ [@osd/config-schema] bootstrap complete
info [@osd/logging] running [osd:bootstrap] script
info [@osd/utils] running [osd:bootstrap] script
succ [@osd/logging] bootstrap complete
succ [@osd/utils] bootstrap complete
info [@osd/apm-config-loader] running [osd:bootstrap] script
info [@osd/dev-utils] running [osd:bootstrap] script
succ [@osd/apm-config-loader] bootstrap complete
succ [@osd/dev-utils] bootstrap complete
info [@osd/ace] running [osd:bootstrap] build targets
info [@osd/analytics] running [osd:bootstrap] script
info [@osd/config] running [osd:bootstrap] script
info [@osd/i18n] running [osd:bootstrap] build targets
succ [@osd/analytics] bootstrap complete
info [@osd/monaco] running [osd:bootstrap] script
succ [@osd/ace] bootstrap complete
info [@osd/opensearch-archiver] running [osd:bootstrap] script
succ [@osd/i18n] bootstrap complete
info [@osd/opensearch] running [osd:bootstrap] script
succ [@osd/config] bootstrap complete
info [@osd/plugin-generator] running [osd:bootstrap] script
succ [@osd/opensearch] bootstrap complete
info [@osd/telemetry-tools] running [osd:bootstrap] script
succ [@osd/telemetry-tools] bootstrap complete
info [@osd/test] running [osd:bootstrap] script
succ [@osd/test] bootstrap complete
succ [@osd/plugin-generator] bootstrap complete
succ [@osd/monaco] bootstrap complete
succ [@osd/opensearch-archiver] bootstrap complete
info [@osd/interpreter] running [osd:bootstrap] script
info [@osd/ui-shared-deps] running [osd:bootstrap] script
succ [@osd/interpreter] bootstrap complete
succ [@osd/ui-shared-deps] bootstrap complete
info [@osd/optimizer] running [osd:bootstrap] script
succ [@osd/optimizer] bootstrap complete
info [@osd/plugin-helpers] running [osd:bootstrap] script
succ [@osd/plugin-helpers] bootstrap complete
info [opensearch-dashboards] running [osd:bootstrap] script
succ [opensearch-dashboards] bootstrap complete
Done in 152.28s.
but maybe it's better for it to be transparent unless there's an error.
ashwin-pc
approved these changes
Sep 1, 2023
|
I like the idea of a log message too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove examples and other unwanted artifacts from installed dependencies using a postinstall script.
List of folders that will be deleted:
Issues Resolved
/node_modules/leaflet-draw/docs/examplesFixes #4722
Fixes #4723
Fixes #4725
Fixes #4727
Fixes #4728
Fixes #4729
/node_modules/leaflet-vega/demoFixes #3525
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr