Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the generated path for downloading plugins by their names on Windows #4953

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Correct the generated path for downloading plugins by their names on Windows #4953

merged 3 commits into from
Sep 7, 2023

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Sep 6, 2023 •
edited
Loading

Description

When OSD plugins are installed by their name, irrespective of the platform:

  • the url path has /tar hard-coded,
  • the url points to a zip file, even though the path is under /tar.

However, experimenting with the URLs, these two worked for me:

This indicates that Windows plugins are not in fact placed in /tar/ but are placed in /zip/.

Issues Resolved

Fixes #4952

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AMoo-Miki
Correct the generated path for downloading plugins by their names on …
699e940 
…Windows

Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki AMoo-Miki force-pushed the fix-plugin-download-win branch from d6e3476 to 699e940 Compare September 6, 2023 23:03
@AMoo-Miki AMoo-Miki changed the title Fix Windows plugins download path Correct the generated path for downloading plugins by their names on Windows Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Merging #4953 (f7c9d2b) into main (d3388c5) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4953      +/-   ##
==========================================
+ Coverage   66.39%   66.45%   +0.06%     
==========================================
  Files        3398     3399       +1     
  Lines       64815    64915     +100     
  Branches    10362    10387      +25     
==========================================
+ Hits        43035    43141     +106     
+ Misses      19300    19210      -90     
- Partials     2480     2564      +84
Flag Coverage Δ
Linux_1 34.80% <ø> (-0.05%) ⬇️
Linux_2 55.31% <ø> (+0.14%) ⬆️
Linux_3 44.46% <ø> (+0.22%) ⬆️
Linux_4 34.89% <100.00%> (-0.03%) ⬇️
Windows_1 34.81% <ø> (-0.05%) ⬇️
Windows_2 55.27% <ø> (+0.15%) ⬆️
Windows_3 44.47% <ø> (+0.22%) ⬆️
Windows_4 34.89% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/cli_plugin/install/settings.js 100.00% <100.00%> (ø)

... and 30 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

kavilla
kavilla previously approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoopsie. Good catch!

I think we can get this into 2.10

joshuarrrr
joshuarrrr previously approved these changes Sep 7, 2023
View reviewed changes
@joshuarrrr joshuarrrr added v2.10.0 and removed v2.11.0 labels Sep 7, 2023
@kavilla
Update snapshot for unit test
34b6d14 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla dismissed stale reviews from joshuarrrr and themself via 34b6d14 September 7, 2023 21:36
@kavilla
Add link for integration to lycheeexlude
f7c9d2b 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from joshuarrrr September 7, 2023 23:20
@joshuarrrr joshuarrrr merged commit 43fe5d5 into opensearch-project:main Sep 7, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
@github-actions
Correct the generated path for downloading plugins by their names on …
af251d0 
…Windows (#4953)

* Correct the generated path for downloading plugins by their names on Windows

Signed-off-by: Miki <miki@amazon.com>

* Update snapshot for unit test

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Add link for integration to lycheeexlude

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 43fe5d5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
@github-actions
Correct the generated path for downloading plugins by their names on …
0f7af80 
…Windows (#4953)

* Correct the generated path for downloading plugins by their names on Windows

Signed-off-by: Miki <miki@amazon.com>

* Update snapshot for unit test

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Add link for integration to lycheeexlude

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 43fe5d5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
kavilla pushed a commit that referenced this pull request Sep 8, 2023
@opensearch-trigger-bot @github-actions
Correct the generated path for downloading plugins by their names on …
062ac82 
…Windows (#4953) (#4971)

* Correct the generated path for downloading plugins by their names on Windows

Signed-off-by: Miki <miki@amazon.com>

* Update snapshot for unit test

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Add link for integration to lycheeexlude

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 43fe5d5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit that referenced this pull request Sep 8, 2023
@opensearch-trigger-bot @github-actions
Correct the generated path for downloading plugins by their names on …
3f57676 
…Windows (#4953) (#4972)

* Correct the generated path for downloading plugins by their names on Windows

Signed-off-by: Miki <miki@amazon.com>

* Update snapshot for unit test

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Add link for integration to lycheeexlude

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 43fe5d5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

Assignees
No one assigned
Labels
backport 2.x distinguished-contributor v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to install OpenSearch Dashboards plugins using its IDs in Windows release
3 participants
@AMoo-Miki @joshuarrrr @kavilla