Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3][CVE-2023-0842] Bump xml2js from 0.4.22 to 0.6.2 #5024

Merged
merged 4 commits into from
Sep 15, 2023
Merged

[1.3][CVE-2023-0842] Bump xml2js from 0.4.22 to 0.6.2 #5024

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80e0796
[1.3][CVE-2023-0842] Bump xml2js from 0.4.22 to 0.6.2
ananzh Sep 14, 2023
7093096
force xml2js to 0.6.2 and fix PR comment
ananzh Sep 14, 2023
bb8b7b3
Merge branch '1.3' into 1.3-xml2js
ananzh Sep 14, 2023
ae071f0
Merge branch '1.3' into 1.3-xml2js
ananzh Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [CVE-2022-1537] Bump grunt from `1.4.1` to `1.5.3` ([#3723](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3723))
- [CVE-2022-0436] Bump grunt from `1.4.1` to `1.5.3` ([#3723](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3723))
- [CVE-2023-26136] Resolve `tough-cookie` to `4.1.3` ([#4682](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4682))
- [CVE-2023-0842] Bump `xml2js` from `0.4.22` to `0.6.2` ([#5024](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5024))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong section - should be under L10.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eeeee... I need to fix others. thank you.


### 📈 Features/Enhancements

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@
"vega-schema-url-parser": "^2.1.0",
"vega-tooltip": "^0.24.2",
"vinyl-fs": "^3.0.3",
"xml2js": "^0.4.22",
"xml2js": "^0.6.2",
"xmlbuilder": "13.0.2",
"zlib": "^1.0.5"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/osd-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"rxjs": "^6.5.5",
"strip-ansi": "^6.0.0",
"tar-fs": "^2.1.0",
"xml2js": "^0.4.22",
"xml2js": "^0.6.2",
"zlib": "^1.0.5"
}
}
10 changes: 9 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22297,7 +22297,7 @@ xml-parse-from-string@^1.0.0:
resolved "https://registry.yarnpkg.com/xml-parse-from-string/-/xml-parse-from-string-1.0.1.tgz#a9029e929d3dbcded169f3c6e28238d95a5d5a28"
integrity sha1-qQKekp09vN7RafPG4oI42VpdWig=

xml2js@^0.4.22, xml2js@^0.4.5:
xml2js@^0.4.5:
version "0.4.22"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we still have a sub-dep requiring 0.4.22. To resolve the CVE, do we need to force a resolution?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you are right. it is brought in by

=> Found "parse-bmfont-xml#xml2js@0.4.23"
info This module exists because "_project_#jimp#@jimp#plugins#@jimp#plugin-print#load-bmfont#parse-bmfont-xml" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "504KB"
info Disk size with transitive dependencies: "504KB"
info Number of shared dependencies: 2

with the latest jimp, we still see xml2js@0.4.23. have to force a resolution. Thank you for checking this carefully. ❤️

resolved "https://registry.yarnpkg.com/xml2js/-/xml2js-0.4.22.tgz#4fa2d846ec803237de86f30aa9b5f70b6600de02"
integrity sha512-MWTbxAQqclRSTnehWWe5nMKzI3VmJ8ltiJEco8akcC6j3miOhjjfzKum5sId+CWhfxdOs/1xauYr8/ZDBtQiRw==
Expand All @@ -22306,6 +22306,14 @@ xml2js@^0.4.22, xml2js@^0.4.5:
util.promisify "~1.0.0"
xmlbuilder "~11.0.0"

xml2js@^0.6.2:
version "0.6.2"
resolved "https://registry.yarnpkg.com/xml2js/-/xml2js-0.6.2.tgz#dd0b630083aa09c161e25a4d0901e2b2a929b499"
integrity sha512-T4rieHaC1EXcES0Kxxj4JWgaUQHDk+qwHcYOCFHfiwKz7tOVPLq7Hjq9dM1WCMhylqMEfP7hMcOIChvotiZegA==
dependencies:
sax ">=0.6.0"
xmlbuilder "~11.0.0"

xmlbuilder@13.0.2:
version "13.0.2"
resolved "https://registry.yarnpkg.com/xmlbuilder/-/xmlbuilder-13.0.2.tgz#02ae33614b6a047d1c32b5389c1fdacb2bce47a7"
Expand Down