Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deangular: removes angular from notify and utils of opendashboards legacy #5085

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -466,4 +466,4 @@
"node": ">=14.20.1 <19",
"yarn": "^1.22.10"
}
}
}
1 change: 0 additions & 1 deletion src/plugins/opensearch_dashboards_legacy/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,3 @@ export const plugin = (initializerContext: PluginInitializerContext) =>
export * from './plugin';

export * from './notify';
export * from './utils';
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,15 @@
*/

import { FatalErrorsSetup } from '../../../../../core/public';
import {
AngularHttpError,
formatAngularHttpError,
isAngularHttpError,
} from './format_angular_http_error';

/**
* Adds an error to the list of fatal errors.
* @deprecated Use `core.fatalErrors.add` instead
*/
export function addFatalError(
fatalErrors: FatalErrorsSetup,
error: AngularHttpError | Error | string,
location?: string
) {
// add support for angular http errors to newPlatformFatalErrors
if (isAngularHttpError(error)) {
error = formatAngularHttpError(error);
}

fatalErrors.add(error, location);
}
fatalErrors: FatalErrorsSetup,

Check failure on line 38 in src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Delete `··`
error: Error | string,

Check failure on line 39 in src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Delete `··`
location?: string

Check failure on line 40 in src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Delete `··`
) {

Check failure on line 41 in src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Delete `··`
fatalErrors.add(error, location);

Check failure on line 42 in src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Delete `··`
}

Check failure on line 43 in src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Replace `··}` with `}⏎`

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,3 @@
export { formatOpenSearchMsg } from './format_opensearch_msg';
export { formatMsg } from './format_msg';
export { formatStack } from './format_stack';
export {
isAngularHttpError,
formatAngularHttpError,
AngularHttpError,
} from './format_angular_http_error';
export { addFatalError } from './add_fatal_error';
Copy link
Member

@ashwin-pc ashwin-pc Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you accidentally deleted this too

37 changes: 0 additions & 37 deletions src/plugins/opensearch_dashboards_legacy/public/utils/index.ts

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading