Fix cigroup 1 with dataGridTable helper functions

[abbyhu2000]

Description

Fix all context related functional tests

Issues Resolved

resolves #5100

[ananzh]

So the primary difference between this one and getLastColumn() is the CSS class selector (euiDataGridRowCell--date vs. euiDataGridRowCell--lastColumn)?

Given this structure, it makes sense to refactor and abstract away the common logic into a single method. What do you think?

Something like

async getDataGridTableSpecificColumnValues(columnSelector: string): Promise<string[]> {
    const table = await find.byCssSelector('.euiDataGrid');
    const $ = await table.parseDomContent();

    const columnValues: string[] = [];
    $.findTestSubjects('dataGridRowCell')
      .toArray()
      .forEach((cell) => {
        const cCell = $(cell);
        if (cCell.hasClass(`euiDataGridRowCell--${columnSelector}`)) {
          // The column structure may be very nested to get the actual text
          columnValues.push(cCell.children().children().children().children().text());
        }
      });

    return columnValues;
}

columnSelector could be date or lastColumn.

[ashwin-pc]

+1 although id keep it simpler like getDataGridTableColumn

[codecov]

Codecov Report

Merging #5105 (7c83660) into feature/deangular (8221fea) will increase coverage by 0.06%.
Report is 1 commits behind head on feature/deangular.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           feature/deangular    #5105      +/-   ##
=====================================================
+ Coverage              66.69%   66.75%   +0.06%     
=====================================================
  Files                   3283     2573     -710     
  Lines                  63059    48335   -14724     
  Branches               10031     8660    -1371     
=====================================================
- Hits                   42056    32267    -9789     
+ Misses                 18537    13952    -4585     
+ Partials                2466     2116     -350     

Flag	Coverage Δ
Linux_1	?
Linux_2	55.23% <ø> (ø)
Linux_3	43.66% <ø> (+<0.01%)	⬆️
Linux_4	35.43% <ø> (ø)
Windows_1	?
Windows_2	?
Windows_3	?
Windows_4	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...n/components/doc_viewer_links/doc_viewer_links.tsx	100.00% <ø> (ø)

... and 793 files with indirect coverage changes

[ashwin-pc]

LGTM, once the comments are addressed this should be good to merge :)

[ashwin-pc]

Do we know why these values changed?

[abbyhu2000]

i had to delete the additional number at the end to make the values matched, i am not sure the cause, but it seems like new data grid table only render 9 digits now? @ananzh

[ashwin-pc]

Can you elaborate a bit more about this? Why should that prevent us from reading the data?

[abbyhu2000]

This function get the text of each table cell using cCell.find('.euiDataGridRowCell__truncate').text(). However, in the new data grid table of data explorer, the data-test-subj of .euiDataGridRowCell__truncate no longer exists.

Also now not every data table cell have the same HTML structure. For example, the timestamp column now has a very nested structure where i can only get the text using cCell.children().children().children().children().text().

While another column like the _source column have a list of <dl> and <dd> elements where we need to traverse through all those elements to get the overall text.

[abbyhu2000]

But it does seem like except for the _source column, all the other table cells can retrieve their text using cCell.children().children().children().children().text()

[ashwin-pc]

+1 although id keep it simpler like getDataGridTableColumn

[ashwin-pc]

The unit test for CI group 3 is failing here. Looks like you need to update a snapshot

[abbyhu2000]

The unit test for CI group 3 is failing here. Looks like you need to update a snapshot

will do

[abbyhu2000]

https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/6304441448/job/17115796891?pr=5105 cigroup1 functional test passing