[BUG][Data Explorer][Discover] Automatically load solo added default index pattern #5171

ananzh · 2023-10-02T20:23:34Z

Description

This fix ensures that when add a default index pattern, Discover will automatically select and load its details.

before

before.mov

after

after.mov

Issues Resolved

closes #5128

Check List

codecov · 2023-10-02T20:41:18Z

Codecov Report

Merging #5171 (0142d81) into main (cb6e0f0) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5171      +/-   ##
==========================================
- Coverage   66.76%   66.73%   -0.04%     
==========================================
  Files        3278     3278              
  Lines       62999    62999              
  Branches    10031    10031              
==========================================
- Hits        42061    42041      -20     
+ Misses      18552    18487      -65     
- Partials     2386     2471      +85

Flag	Coverage Δ
Linux_1	`35.31% <ø> (ø)`
Linux_2	`55.24% <ø> (ø)`
Linux_3	`43.74% <ø> (-0.01%)`	⬇️
Linux_4	`35.42% <ø> (ø)`
Windows_1	`?`
Windows_2	`55.20% <ø> (ø)`
Windows_3	`?`
Windows_4	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

AMoo-Miki · 2023-10-02T23:42:17Z

src/plugins/discover/public/application/view_components/utils/use_index_pattern.ts

+      const indexPatternMissingWarning = i18n.translate(
+        'discover.valueIsNotConfiguredIndexPatternIDWarningTitle',
+        {
+          defaultMessage: '{id} is not a configured index pattern ID',
+          values: {
+            id: `"${id}"`,
+          },
        }
+      );
+
+      data.indexPatterns
+        .get(id)
+        .then((result) => {
+          if (isMounted) {
+            setIndexPattern(result);
+          }
+        })
+        .catch(() => {
+          if (isMounted) {
+            toastNotifications.addDanger({
+              title: indexPatternMissingWarning,
+            });
+          }
+        });
+    };


Let's move indexPatternMissingWarning inside the catch, where it is being used.

Suggested change

const indexPatternMissingWarning = i18n.translate(

'discover.valueIsNotConfiguredIndexPatternIDWarningTitle',

{

defaultMessage: '{id} is not a configured index pattern ID',

values: {

id: `"${id}"`,

},

}

);

data.indexPatterns

.get(id)

.then((result) => {

if (isMounted) {

setIndexPattern(result);

}

})

.catch(() => {

if (isMounted) {

toastNotifications.addDanger({

title: indexPatternMissingWarning,

});

}

});

};

data.indexPatterns

.get(id)

.then((result) => {

if (isMounted) {

setIndexPattern(result);

}

})

.catch(() => {

if (isMounted) {

const indexPatternMissingWarning = i18n.translate(

'discover.valueIsNotConfiguredIndexPatternIDWarningTitle',

{

defaultMessage: '{id} is not a configured index pattern ID',

values: {

id: `"${id}"`,

},

}

);

toastNotifications.addDanger({

title: indexPatternMissingWarning,

});

}

});

};

ashwin-pc

This looks good, needs to be rebased based on https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5168/files#diff-663ffea1a92b4c32f69ad6a65f15d9b07ae759bc026568db627d950842fcad07 though since there is a little overlap

ashwin-pc · 2023-10-02T20:36:45Z

src/plugins/discover/public/application/view_components/canvas/discover_table.tsx

@@ -71,7 +72,7 @@ export const DiscoverTable = ({ history }: Props) => {
  );

  const { rows } = fetchState || {};
-  const { savedSearch } = useSearch(services);
+  const { savedSearch } = useSearch(services, store);


We dont need to use useSearch here again. useDiscoverContext should have all the values you need i.e. savedSearch

ashwin-pc · 2023-10-03T02:47:14Z

src/plugins/discover/public/application/view_components/context/index.tsx

  } = useOpenSearchDashboards<DataExplorerServices>();

+  const searchParams = useSearch(services, store);


This change wont be necessary with my change here: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5168/files#diff-663ffea1a92b4c32f69ad6a65f15d9b07ae759bc026568db627d950842fcad07

…index pattern This fix ensures that when add a default index pattern, Discover will automatically select and load its details. Issue Resolve opensearch-project#5128 Signed-off-by: ananzh <ananzh@amazon.com>

Signed-off-by: ananzh <ananzh@amazon.com>

…index pattern (#5171) * [BUG][Data Explorer][Discover] Automatically load solo added default index pattern This fix ensures that when add a default index pattern, Discover will automatically select and load its details. Issue Resolve #5128 --------- Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 9601c6c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

…index pattern (#5171) (#5189) * [BUG][Data Explorer][Discover] Automatically load solo added default index pattern This fix ensures that when add a default index pattern, Discover will automatically select and load its details. Issue Resolve #5128 --------- Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 9601c6c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…default index pattern (#5171) (#5189)" This reverts commit d1bca33.

…default index pattern (#5171) (#5189)" (#5199) This reverts commit d1bca33.

AMoo-Miki · 2023-10-04T05:16:11Z

The backport to 2.x was reverted to orchestrate the merging of all the 2.x PRs.

…index pattern (opensearch-project#5171) * [BUG][Data Explorer][Discover] Automatically load solo added default index pattern This fix ensures that when add a default index pattern, Discover will automatically select and load its details. Issue Resolve opensearch-project#5128 --------- Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 9601c6c) Signed-off-by: Miki <miki@amazon.com>

* [BUG][Discover] Add onQuerySubmit to top nav and allow force update to embeddable (#5160) * all reload to force update embeddable * add onQuerySubmit to top nav Issue Resolve #5116 #5159 Signed-off-by: ananzh <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 7d89cca) Signed-off-by: Miki <miki@amazon.com> * [Discover] A bunch of navigation fixes (#5168) * Discover: Fixes state persistence after nav * Fixed breadcrumbs and navigation * fixes mobile view --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit cb6e0f0) Signed-off-by: Miki <miki@amazon.com> * [BUG][Data Explorer][Discover] Automatically load solo added default index pattern (#5171) * [BUG][Data Explorer][Discover] Automatically load solo added default index pattern This fix ensures that when add a default index pattern, Discover will automatically select and load its details. Issue Resolve #5128 --------- Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 9601c6c) Signed-off-by: Miki <miki@amazon.com> * [BUG][Data Explorer][Discover] Allow data grid to auto adjust size based on fetched data count (#5191) * This PR adds a new rows state to the DiscoverCanvas component and updated it whenever the data$ observable emitted new row data. * The DiscoverTable component was then refactored to accept rows as a prop, making it dependent on the parent component to provide the correct set of data. This ensures that the table renders correctly based on the current data and doesn't rely on its internal state, which could be outdated. Issue Resolve #5181 Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 677fdf5) Signed-off-by: Miki <miki@amazon.com> * Fixes mobile layout (#5195) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 0ffd2ab) * [BUG][Data Explorer][Discover] Allow filter and query persist when refresh page or paste url to a new tab (#5206) Issue Resolve #5179 #5071 Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 5623cef) Signed-off-by: Miki <miki@amazon.com> * fixes DataTable rendering in doscover (#5207) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit c70125f) --------- Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

…index pattern (opensearch-project#5171) * [BUG][Data Explorer][Discover] Automatically load solo added default index pattern This fix ensures that when add a default index pattern, Discover will automatically select and load its details. Issue Resolve opensearch-project#5128 --------- Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: Willie Hung <willie880201044@gmail.com>

…index pattern (opensearch-project#5171) * [BUG][Data Explorer][Discover] Automatically load solo added default index pattern This fix ensures that when add a default index pattern, Discover will automatically select and load its details. Issue Resolve opensearch-project#5128 --------- Signed-off-by: ananzh <ananzh@amazon.com>

ananzh requested review from kavilla, seanneumann, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy and curq as code owners October 2, 2023 20:23

github-actions bot added the distinguished-contributor label Oct 2, 2023

ananzh force-pushed the fix-5128 branch from e09cfc1 to e6773ff Compare October 2, 2023 20:25

ananzh assigned ananzh and ashwin-pc Oct 2, 2023

ananzh added bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent v2.11.0 backport 2.x labels Oct 2, 2023

AMoo-Miki reviewed Oct 2, 2023

View reviewed changes

ashwin-pc reviewed Oct 3, 2023

View reviewed changes

[BUG][Data Explorer][Discover] Automatically load solo added default …

88c658e

…index pattern This fix ensures that when add a default index pattern, Discover will automatically select and load its details. Issue Resolve opensearch-project#5128 Signed-off-by: ananzh <ananzh@amazon.com>

ananzh force-pushed the fix-5128 branch from b185097 to 9a6b86c Compare October 3, 2023 20:20

fix PR comments

0142d81

Signed-off-by: ananzh <ananzh@amazon.com>

ananzh force-pushed the fix-5128 branch from 9a6b86c to 0142d81 Compare October 3, 2023 20:23

AMoo-Miki approved these changes Oct 3, 2023

View reviewed changes

ashwin-pc approved these changes Oct 3, 2023

View reviewed changes

ananzh merged commit 9601c6c into opensearch-project:main Oct 3, 2023
49 of 55 checks passed

opensearch-trigger-bot bot mentioned this pull request Oct 3, 2023

[Backport 2.x] [BUG][Data Explorer][Discover] Automatically load solo added default index pattern #5189

Merged

AMoo-Miki added a commit that referenced this pull request Oct 4, 2023

Revert "[BUG][Data Explorer][Discover] Automatically load solo added …

89cf0b2

…default index pattern (#5171) (#5189)" This reverts commit d1bca33.

AMoo-Miki added a commit that referenced this pull request Oct 4, 2023

Revert "[BUG][Data Explorer][Discover] Automatically load solo added …

d59ee39

…default index pattern (#5171) (#5189)" (#5199) This reverts commit d1bca33.

AMoo-Miki mentioned this pull request Oct 4, 2023

[Manual 2.x] De-angular backports collection #5219

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG][Data Explorer][Discover] Automatically load solo added default index pattern #5171

[BUG][Data Explorer][Discover] Automatically load solo added default index pattern #5171

ananzh commented Oct 2, 2023 •

edited

Loading

codecov bot commented Oct 2, 2023 •

edited

Loading

AMoo-Miki Oct 2, 2023 •

edited

Loading

ashwin-pc left a comment

ashwin-pc Oct 2, 2023

ashwin-pc Oct 3, 2023

AMoo-Miki commented Oct 4, 2023

		} = useOpenSearchDashboards<DataExplorerServices>();

		const searchParams = useSearch(services, store);

[BUG][Data Explorer][Discover] Automatically load solo added default index pattern #5171

[BUG][Data Explorer][Discover] Automatically load solo added default index pattern #5171

Conversation

ananzh commented Oct 2, 2023 • edited Loading

Description

Issues Resolved

Check List

codecov bot commented Oct 2, 2023 • edited Loading

Codecov Report

AMoo-Miki Oct 2, 2023 • edited Loading

Choose a reason for hiding this comment

ashwin-pc left a comment

Choose a reason for hiding this comment

ashwin-pc Oct 2, 2023

Choose a reason for hiding this comment

ashwin-pc Oct 3, 2023

Choose a reason for hiding this comment

AMoo-Miki commented Oct 4, 2023

ananzh commented Oct 2, 2023 •

edited

Loading

codecov bot commented Oct 2, 2023 •

edited

Loading

AMoo-Miki Oct 2, 2023 •

edited

Loading