Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Explorer] Removed X icon in data source selection. #5238

Merged
merged 4 commits into from
Oct 10, 2023
Merged

[Data Explorer] Removed X icon in data source selection. #5238

merged 4 commits into from
Oct 10, 2023

Conversation

Abilashinamdar
Copy link
Contributor

@Abilashinamdar Abilashinamdar commented Oct 6, 2023 •
edited by ashwin-pc
Loading

Description

Removed Discover datasource selector X icon

Issues Resolved

fixes #5229

Screenshot

Screenshot from 2023-10-06 15-24-13

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

removed X icon in data source selection.
1b301d1 
Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #5238 (b4e679a) into main (d6345f3) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5238      +/-   ##
==========================================
- Coverage   66.78%   66.74%   -0.04%     
==========================================
  Files        3284     3284              
  Lines       63092    63092              
  Branches    10048    10048              
==========================================
- Hits        42133    42109      -24     
- Misses      18491    18586      +95     
+ Partials     2468     2397      -71
Flag Coverage Δ
Linux_1 35.26% <ø> (ø)
Linux_2 ?
Linux_3 43.85% <ø> (+<0.01%) ⬆️
Linux_4 35.36% <ø> (-0.01%) ⬇️
Windows_1 35.28% <ø> (ø)
Windows_2 55.20% <ø> (ø)
Windows_3 43.85% <ø> (ø)
Windows_4 35.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rces/datasource_selector/datasource_selectable.tsx 64.86% <ø> (ø)

... and 21 files with indirect coverage changes

@ashwin-pc
Copy link
Member

@Abilashinamdar wow thanks! this is a really quick and good fix. Totally missed that prop. Can you add a changelog for your change?

updated changelog
4d18c78 
Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>
@Abilashinamdar
Copy link
Contributor Author

Abilashinamdar commented Oct 7, 2023 •
edited
Loading

@Abilashinamdar wow thanks! this is a really quick and good fix. Totally missed that prop. Can you add a changelog for your change?

@ashwin-pc , I have Updated the changelog.md.
I have manually updated it so are we following any automated command to update?

@ashwin-pc
Merge branch 'main' into fix-5229
b36441f 
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc changed the title removed X icon in data source selection. [Data Explorer] Removed X icon in data source selection. Oct 10, 2023
ashwin-pc
ashwin-pc previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@ashwin-pc ashwin-pc added backport 2.x data explorer Issues related to the Data Explorer project v2.11.0 backport 2.11 labels Oct 10, 2023
@AMoo-Miki
Update CHANGELOG.md
b4e679a 
Signed-off-by: Miki <amoo_miki@yahoo.com>
@ashwin-pc ashwin-pc merged commit df08387 into opensearch-project:main Oct 10, 2023
55 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2023
@github-actions
[Data Explorer] Removed X icon in data source selection. (#5238)
d230640 
* removed X icon in data source selection.

Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>

* updated changelog

Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>

* Update CHANGELOG.md

Signed-off-by: Miki <amoo_miki@yahoo.com>

---------

Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Miki <amoo_miki@yahoo.com>
Co-authored-by: Abhilash <abhilash.bhimanna@senecaglobal.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit df08387)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 10, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2023
@github-actions
[Data Explorer] Removed X icon in data source selection. (#5238)
a8cfe44 
* removed X icon in data source selection.

Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>

* updated changelog

Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>

* Update CHANGELOG.md

Signed-off-by: Miki <amoo_miki@yahoo.com>

---------

Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Miki <amoo_miki@yahoo.com>
Co-authored-by: Abhilash <abhilash.bhimanna@senecaglobal.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit df08387)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 10, 2023
Merged
ananzh pushed a commit that referenced this pull request Oct 10, 2023
@opensearch-trigger-bot @ashwin-pc @AMoo-Miki
[Data Explorer] Removed X icon in data source selection. (#5238) (#5264)
cf9a97a 
* removed X icon in data source selection.

---------

Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Miki <amoo_miki@yahoo.com>
Co-authored-by: Abhilash <abhilash.bhimanna@senecaglobal.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit df08387)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this pull request Oct 10, 2023
@opensearch-trigger-bot @github-actions
[Data Explorer] Removed X icon in data source selection. (#5238) (#5265)
88a750f 
* removed X icon in data source selection.

Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>

* updated changelog

Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>

* Update CHANGELOG.md

Signed-off-by: Miki <amoo_miki@yahoo.com>

---------

Signed-off-by: Abhilash <abhilash.bhimanna@senecaglobal.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Miki <amoo_miki@yahoo.com>
Co-authored-by: Abhilash <abhilash.bhimanna@senecaglobal.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit df08387)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@ashwin-pc ashwin-pc ashwin-pc left review comments

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

Assignees
No one assigned
Labels
backport 2.x data explorer Issues related to the Data Explorer project first-time-contributor v2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Discover datasource selector X should be removed
4 participants
@Abilashinamdar @ashwin-pc @AMoo-Miki @ananzh