Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSCI][Doc]Updated EUI doc site links to OUI doc site #5293

Merged
merged 3 commits into from
Oct 16, 2023
Merged

[OSCI][Doc]Updated EUI doc site links to OUI doc site #5293

merged 3 commits into from
Oct 16, 2023

Conversation

vvavdiya
Copy link
Contributor

Description

[Docs] Update EUI doc site links to point to OUI doc site

Issues Resolved

Fix #2862:Update EUI doc site links to point to OUI doc site

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@vvavdiya
[OSCI][Doc]Updated EUI doc site links to OUI doc site
ced4940 
Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>
@vvavdiya
[OSCI][Doc]Updated PR details in CHANGELOG
4008f25 
Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>
@vvavdiya
Copy link
Contributor Author

@joshuarrrr
PR available for review.

Thanks

BigSamu
BigSamu approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@BigSamu BigSamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashwin-pc
ashwin-pc approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM :)

@BSFishy BSFishy added the OSCI Open Source Contributor Initiative label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #5293 (588b710) into main (60f4c8f) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5293      +/-   ##
==========================================
- Coverage   66.77%   66.74%   -0.04%     
==========================================
  Files        3284     3284              
  Lines       63095    63095              
  Branches    10049    10049              
==========================================
- Hits        42134    42110      -24     
+ Misses      18488    18487       -1     
- Partials     2473     2498      +25
Flag Coverage Δ
Linux_1 35.26% <ø> (ø)
Linux_2 ?
Linux_3 ?
Linux_4 35.36% <ø> (ø)
Windows_1 35.27% <ø> (ø)
Windows_2 55.20% <ø> (ø)
Windows_3 43.85% <ø> (ø)
Windows_4 35.36% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/server/services/tutorials/lib/tutorial_schema.ts 100.00% <ø> (ø)

... and 20 files with indirect coverage changes

kavilla
kavilla approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 thanks!

@joshuarrrr joshuarrrr merged commit 534b2d0 into opensearch-project:main Oct 16, 2023
126 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 16, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 16, 2023
@github-actions
[OSCI][Doc]Updated EUI doc site links to OUI doc site (#5293)
7e7ebfc 
* [OSCI][Doc]Updated EUI doc site links to OUI doc site

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>

* [OSCI][Doc]Updated PR details in CHANGELOG

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>

---------

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit 534b2d0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ananzh pushed a commit that referenced this pull request Oct 17, 2023
@opensearch-trigger-bot @ashwin-pc
@github-actions @joshuarrrr
[OSCI][Doc]Updated EUI doc site links to OUI doc site (#5293) (#5308)
acc0c98 
* [OSCI][Doc]Updated EUI doc site links to OUI doc site
* [OSCI][Doc]Updated PR details in CHANGELOG

---------

Signed-off-by: Vijay Vavdiya <vijayvavdiya@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit 534b2d0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigSamu BigSamu BigSamu approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@kavilla kavilla kavilla approved these changes

@BSFishy BSFishy BSFishy approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

Assignees
No one assigned
Labels
backport 2.x first-time-contributor OSCI Open Source Contributor Initiative v2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Update EUI doc site links to point to OUI doc site
6 participants
@vvavdiya @joshuarrrr @BSFishy @kavilla @ashwin-pc @BigSamu