Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OuiSelect component with OuiSuperSelect in data-source plugin #5315

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

bandinib-amzn
Copy link
Member

@bandinib-amzn bandinib-amzn commented Oct 17, 2023

Description

Replace OuiSelect component with OuiSuperSelect in data-source plugin

Screenshot

Screenshot 2023-10-17 at 2 58 50 PM Screenshot 2023-10-17 at 2 59 23 PM

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6710ec3) 67.02% compared to head (40b207e) 67.02%.

Files Patch % Lines
...components/create_form/create_data_source_form.tsx 75.00% 1 Missing ⚠️
...rce/components/edit_form/edit_data_source_form.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5315      +/-   ##
==========================================
- Coverage   67.02%   67.02%   -0.01%     
==========================================
  Files        3294     3294              
  Lines       63309    63307       -2     
  Branches    10071    10071              
==========================================
- Hits        42435    42430       -5     
- Misses      18430    18431       +1     
- Partials     2444     2446       +2     
Flag Coverage Δ
Linux_1 35.24% <ø> (ø)
Linux_2 55.19% <ø> (ø)
Linux_3 43.86% <71.42%> (-0.01%) ⬇️
Linux_4 35.34% <ø> (-0.01%) ⬇️
Windows_1 35.26% <ø> (ø)
Windows_2 55.15% <ø> (ø)
Windows_3 43.88% <71.42%> (-0.01%) ⬇️
Windows_4 35.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bandinib-amzn bandinib-amzn force-pushed the ux-fix branch 3 times, most recently from 6abe9f8 to d6514c4 Compare October 19, 2023 19:49
Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
bandinib-amzn and others added 2 commits December 21, 2023 22:46
Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
@bandinib-amzn bandinib-amzn merged commit 18607a2 into opensearch-project:main Jan 8, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 8, 2024
…#5315)

* Replace OuiSelect component with OuiSuperSelect in data-source plugin

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

* Fix UT

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

---------

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit 18607a2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@bandinib-amzn bandinib-amzn deleted the ux-fix branch January 8, 2024 19:58
manasvinibs pushed a commit that referenced this pull request Jan 31, 2024
…#5315) (#5666)

* Replace OuiSelect component with OuiSuperSelect in data-source plugin



* Fix UT



---------


(cherry picked from commit 18607a2)

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants