Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Run plugin functional tests within Github #5371

Closed
wants to merge 8 commits into from
Closed

[CI] Run plugin functional tests within Github #5371

wants to merge 8 commits into from

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Oct 25, 2023 •
edited
Loading

Description

Previously Plugin functional tests were not execute within the Github actions.

Building and running the tests with:

node scripts/functional_tests.js --config test/plugin_functional/config.js

Issues Resolved

n/a

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@kavilla
[CI] Run plugin functional tests within Github
ba653ab 
Previously Plugin functional tests were not execute within
the Github actions.

Building and running the tests with:
```
node scripts/functional_tests.js --config test/plugin_functional/config.js
```

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
abbyhu2000 and others added 5 commits October 25, 2023 02:15
@abbyhu2000
skip
494ac71 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@kavilla
no more js
ee52dbf 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@abbyhu2000
fix try #1
b066c1a 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@kavilla
fix file
250d41b 
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla
Merge branch 'kavilla/add_plugin_func' of github.com:kavilla/OpenSear…
5a9c0e3 
…ch-Dashboards-1 into kavilla/add_plugin_func
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #5371 (ba653ab) into main (e1db842) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head ba653ab differs from pull request most recent head e9ce23e. Consider uploading reports for the commit e9ce23e to get more accurate results

@@           Coverage Diff           @@
##             main    #5371   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files        3286     3286           
  Lines       63148    63148           
  Branches    10054    10054           
=======================================
+ Hits        42191    42193    +2     
- Misses      18475    18478    +3     
+ Partials     2482     2477    -5
Flag Coverage Δ
Linux_1 35.24% <ø> (ø)
Linux_2 55.25% <ø> (ø)
Linux_3 43.82% <ø> (ø)
Linux_4 35.34% <ø> (ø)
Windows_1 35.25% <ø> (ø)
Windows_2 55.22% <ø> (ø)
Windows_3 43.83% <ø> (+<0.01%) ⬆️
Windows_4 35.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@abbyhu2000
Skip custom doc link test
e5f373c 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000
Change test name
e9ce23e 
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000
Copy link
Member

Will be resolves in #5383

@abbyhu2000 abbyhu2000 closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh will be requested when the pull request is marked ready for review ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki will be requested when the pull request is marked ready for review AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc will be requested when the pull request is marked ready for review ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr will be requested when the pull request is marked ready for review joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 will be requested when the pull request is marked ready for review abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon will be requested when the pull request is marked ready for review zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu will be requested when the pull request is marked ready for review zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs will be requested when the pull request is marked ready for review manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX will be requested when the pull request is marked ready for review ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub will be requested when the pull request is marked ready for review Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq will be requested when the pull request is marked ready for review curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn will be requested when the pull request is marked ready for review bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe will be requested when the pull request is marked ready for review SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl will be requested when the pull request is marked ready for review ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT will be requested when the pull request is marked ready for review BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba will be requested when the pull request is marked ready for review xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi will be requested when the pull request is marked ready for review zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric will be requested when the pull request is marked ready for review mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 will be requested when the pull request is marked ready for review LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi will be requested when the pull request is marked ready for review virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli will be requested when the pull request is marked ready for review sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 will be requested when the pull request is marked ready for review joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo will be requested when the pull request is marked ready for review huyaboo is a code owner

Assignees
No one assigned
Labels
distinguished-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavilla @abbyhu2000