Fix missing customApiRegistryPromise param for test connection #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
Signed-off-by: Lu Yu <nluyu@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5944 +/- ##
==========================================
+ Coverage 67.00% 67.01% +0.01%
==========================================
Files 3307 3310 +3
Lines 63614 63647 +33
Branches 10163 10165 +2
==========================================
+ Hits 42626 42656 +30
- Misses 18518 18522 +4
+ Partials 2470 2469 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lu Yu <nluyu@amazon.com>
7 tasks
Signed-off-by: Lu Yu <nluyu@amazon.com>
bandinib-amzn
approved these changes
Feb 27, 2024
|
@BionIT we probably need to add label for the backport 2.x 2.13, and may need to 2.12 as well |
Flyingliuhub
added
multiple datasource
| @@ -129,7 +129,8 @@ export class DataSourcePlugin implements Plugin<DataSourcePluginSetup, DataSourc | |||
| router, | |||
| dataSourceService, | |||
| cryptographyServiceSetup, | |||
| authRegistryPromise | |||
| authRegistryPromise, | |||
| customApiSchemaRegistryPromise | |||
There was a problem hiding this comment.
Do we know how this went missing in the first place?
There was a problem hiding this comment.
We need to add more tests for MDS to capture things like this, and I have added the only test for the test connection router. Can we fix this issue first then add more tests?
custom API registry is new and not released in 2.12 |
Flyingliuhub
approved these changes
Feb 27, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5944-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6d5560e00c31748ddfbcd031241d67abaaf58c91
# Push it to GitHub
git push --set-upstream origin backport/backport-5944-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
28 tasks
BionIT
added a commit
to BionIT/OpenSearch-Dashboards
that referenced
this pull request
Feb 27, 2024
…earch-project#5944) * fix missing param and add changelog and test Signed-off-by: Lu Yu <nluyu@amazon.com> * change pr number Signed-off-by: Lu Yu <nluyu@amazon.com> * remove dangling changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
Merged
7 tasks
ZilongX
pushed a commit
that referenced
this pull request
Feb 27, 2024
…est connection (#5944) (#5971) * Fix missing customApiRegistryPromise param for test connection (#5944) * fix missing param and add changelog and test Signed-off-by: Lu Yu <nluyu@amazon.com> * change pr number Signed-off-by: Lu Yu <nluyu@amazon.com> * remove dangling changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> * remove dangling changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 4, 2024
…earch-project#5944) * fix missing param and add changelog and test Signed-off-by: Lu Yu <nluyu@amazon.com> * change pr number Signed-off-by: Lu Yu <nluyu@amazon.com> * remove dangling changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
|
Manual Backport #5971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds custom API registry to the test connection route
Issues Resolved
Fixes #5937
Screenshot
bug.mp4
Testing the changes
The following steps were followed:
enabled data source plugin
click test connection and should be successful
Check List
yarn test:jestyarn test:jest_integration