Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating MAINTAINERS.md with correct links #600

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Updating MAINTAINERS.md with correct links #600

merged 1 commit into from
Jul 23, 2021

Conversation

ahopp
Copy link
Contributor

@ahopp ahopp commented Jul 8, 2021 •
edited by tmarkley
Loading

Description

  • Add path to .github maintainer doc.
  • Add path to CONTRIBUTING.md

Issues Resolved

Partially Resolve: Issue #592

@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed d1df837
Run ./dev-tools/signoff-check.sh remotes/origin/main d1df837faf10014235dc6908f2ad7f238dcc1d44 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@kavilla kavilla self-requested a review July 8, 2021 18:30
@kavilla
Copy link
Member

kavilla commented Jul 8, 2021

Same as the other PR, will need the commit to be signed.

@ahopp ahopp changed the title Update MAINTAINERS.md Updating MAINTAINERS.md with correct links Jul 8, 2021
@ahopp
Copy link
Contributor Author

ahopp commented Jul 8, 2021

Same as the other PR, will need the commit to be signed.

Signed and added more descriptive title. Thanks!!

Update MAINTAINERS.md
d032bc2 
* Add path to .github maintainer doc
* Add path to CONTRIBUTING.md

Signed-off-by: Tommy Markley <markleyt@amazon.com>
@tmarkley tmarkley requested review from ananzh and boktorbb July 23, 2021 16:21
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed d032bc2

mihirsoni
mihirsoni approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@tmarkley tmarkley merged commit 66cf55f into main Jul 23, 2021
@tmarkley tmarkley deleted the ahopp-patch-3 branch July 23, 2021 17:41
@tmarkley tmarkley mentioned this pull request Jul 23, 2021
Closed
30 tasks
tmarkley pushed a commit to tmarkley/OpenSearch-Dashboards that referenced this pull request Jul 23, 2021
@ahopp
Update MAINTAINERS.md (opensearch-project#600)
e288f21 
* Add path to .github maintainer doc
* Add path to CONTRIBUTING.md

Signed-off-by: Tommy Markley <markleyt@amazon.com>

Co-authored-by: Tommy Markley <markleyt@amazon.com>
@tmarkley tmarkley mentioned this pull request Jul 23, 2021
Merged
1 task
tmarkley pushed a commit that referenced this pull request Jul 26, 2021
@ahopp
Update MAINTAINERS.md (#600) (#664)
11925fb 
* Add path to .github maintainer doc
* Add path to CONTRIBUTING.md

Signed-off-by: Tommy Markley <markleyt@amazon.com>

Co-authored-by: Tommy Markley <markleyt@amazon.com>

Co-authored-by: Andrew Hopp <andrew.hopp@me.com>
@tmarkley tmarkley added the docs Improvements or additions to documentation label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@mihirsoni mihirsoni mihirsoni approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@boktorbb boktorbb Awaiting requested review from boktorbb

Assignees
No one assigned
Labels
docs Improvements or additions to documentation v1.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahopp @opensearch-ci-bot @kavilla @mihirsoni @tmarkley