[Discover] Fix lazy loading #6041
Merged
+22
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
ashwin-pc
requested review from
ananzh,
kavilla,
AMoo-Miki,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
BionIT
as code owners
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6041 +/- ##
==========================================
- Coverage 67.15% 67.13% -0.02%
==========================================
Files 3317 3317
Lines 64016 64016
Branches 10256 10256
==========================================
- Hits 42991 42979 -12
- Misses 18533 18545 +12
Partials 2492 2492
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ananzh
approved these changes
Mar 5, 2024
|
Resolve #6033 |
7 tasks
abbyhu2000
approved these changes
Mar 5, 2024
ananzh
pushed a commit
that referenced
this pull request
Mar 5, 2024
* adds callback ref to lazy loading sentinel --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Apr 7, 2024
* adds callback ref to lazy loading sentinel --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
SuZhou-Joe
pushed a commit
to ruanyl/OpenSearch-Dashboards
that referenced
this pull request
Apr 7, 2024
* adds callback ref to lazy loading sentinel --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
* adds callback ref to lazy loading sentinel --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit bb8155a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
added a commit
that referenced
this pull request
Apr 25, 2024
* adds callback ref to lazy loading sentinel --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit bb8155a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sentinel object in the legacy table on first page load (without query params) was being set after the component rendered for the first time. This caused the observer to not be set properly. This change triggers the effect only once the sentinel is actually attached to the DOM node
Issues Resolved
fixes #6033
Screenshot
Before:
Screen.Recording.2024-03-05.at.12.03.16.PM.mov
After:
Screen.Recording.2024-03-05.at.12.04.03.PM.mov
Testing the changes
Check List
yarn test:jestyarn test:jest_integration