-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MD] Expose a few properties for customize the appearance of the data source selector component #6057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe and
ruanyl
as code owners
March 6, 2024 22:32
BionIT
changed the title
Expose a few properties for customize the appearance of the data source selector component
[MD] Expose a few properties for customize the appearance of the data source selector component
Mar 6, 2024
Signed-off-by: Lu Yu <nluyu@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6057 +/- ##
=======================================
Coverage 67.13% 67.13%
=======================================
Files 3318 3318
Lines 64021 64037 +16
Branches 10256 10266 +10
=======================================
+ Hits 42981 42992 +11
Misses 18548 18548
- Partials 2492 2497 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
added
v2.13.0
backport 2.x
multiple datasource
multiple datasource project
labels
Mar 7, 2024
ZilongX
approved these changes
Mar 7, 2024
xinruiba
approved these changes
Mar 7, 2024
bandinib-amzn
approved these changes
Mar 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
… source selector component (#6057) * allow customize picker Signed-off-by: Lu Yu <nluyu@amazon.com> * fix placeholder Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit 144c022) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BionIT
pushed a commit
that referenced
this pull request
Mar 8, 2024
… source selector component (#6057) (#6063) * allow customize picker Signed-off-by: Lu Yu <nluyu@amazon.com> * fix placeholder Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit 144c022) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change exposes a few properties like
Select a data source
Issues Resolved
Fixes #5992
Screenshot
customizepicker.mp4
Testing the changes
The following steps are performed in the recording above:
Check List
yarn test:jest
yarn test:jest_integration