-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Clean concepts in packages/osd-plugin-generator/README.md #609
Merged
mihirsoni
merged 1 commit into
opensearch-project:main
from
ananzh:fix_osd_plugin_generator
Jul 9, 2021
Merged
[Bug] Clean concepts in packages/osd-plugin-generator/README.md #609
mihirsoni
merged 1 commit into
opensearch-project:main
from
ananzh:fix_osd_plugin_generator
Jul 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The versions in packages/osd-plugin-generator/README.md are still 6.x which should be updated to 1.0. Meanwhile, there are some old concepts, like test using mocha, which should be cleaned. This PR fixes the versions and cleans out the old concepts. Partically Resolved: opensearch-project#592 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
force-pushed
the
fix_osd_plugin_generator
branch
from
July 9, 2021 01:01
62f1546
to
1b4d2f9
Compare
30 tasks
✅ DCO Check Passed 1b4d2f9 |
kavilla
approved these changes
Jul 9, 2021
mihirsoni
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Jul 9, 2021
The versions in packages/osd-plugin-generator/README.md are still 6.x which should be updated to 1.0. Meanwhile, there are some old concepts, like test using mocha, which should be cleaned. This PR fixes the versions and cleans out the old concepts. Partically Resolved: opensearch-project#592 Backport PR: opensearch-project#609 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Jul 9, 2021
The versions in packages/osd-plugin-generator/README.md are still 6.x which should be updated to 1.0. Meanwhile, there are some old concepts, like test using mocha, which should be cleaned. This PR fixes the versions and cleans out the old concepts. Partically Resolved: opensearch-project#592 Backport PR: opensearch-project#609 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
This was referenced Jul 9, 2021
ananzh
added a commit
that referenced
this pull request
Jul 11, 2021
The versions in packages/osd-plugin-generator/README.md are still 6.x which should be updated to 1.0. Meanwhile, there are some old concepts, like test using mocha, which should be cleaned. This PR fixes the versions and cleans out the old concepts. Partically Resolved: #592 Backport PR: #609 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
that referenced
this pull request
Jul 11, 2021
The versions in packages/osd-plugin-generator/README.md are still 6.x which should be updated to 1.0. Meanwhile, there are some old concepts, like test using mocha, which should be cleaned. This PR fixes the versions and cleans out the old concepts. Partically Resolved: #592 Backport PR: #609 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The versions in packages/osd-plugin-generator/README.md are still 6.x
which should be updated to 1.0. Meanwhile, there are some old concepts,
like test using mocha, which should be cleaned. This PR fixes the versions
and cleans out the old concepts.
Partically Resolved:
#592
Signed-off-by: Anan Zhuang ananzh@amazon.com
Check List