Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Clean concepts in packages/osd-plugin-helpers/README.md #610

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jul 9, 2021

Description

The versions in packages/osd-plugin-helpers/README.md are still 6.3
which should be updated to 1.0. Meanwhile, there are some old concepts,
like checking versions, which should be cleaned. This PR fixes the
versions and cleans out the old concepts.

Partically Resolved:

#592

Signed-off-by: Anan Zhuang ananzh@amazon.com

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

The versions in packages/osd-plugin-helpers/README.md are still 6.3
which should be updated to 1.0. Meanwhile, there are some old concepts,
like checking versions, which should be cleaned. This PR fixes the
versions and cleans out the old concepts.

Partically Resolved:
opensearch-project#592

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh added bug Something isn't working v1.0.0 labels Jul 9, 2021
@ananzh ananzh requested review from tmarkley, ahopp and kavilla July 9, 2021 01:24
@ananzh ananzh self-assigned this Jul 9, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 1836f5d

@ananzh ananzh requested review from seraphjiang and mihirsoni July 9, 2021 17:53
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thanks for the changes.

@mihirsoni mihirsoni merged commit 77b745d into opensearch-project:main Jul 9, 2021
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 9, 2021
The versions in packages/osd-plugin-helpers/README.md are still 6.3
which should be updated to 1.0. Meanwhile, there are some old concepts,
like checking versions, which should be cleaned. This PR fixes the
versions and cleans out the old concepts.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#610

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 9, 2021
The versions in packages/osd-plugin-helpers/README.md are still 6.3
which should be updated to 1.0. Meanwhile, there are some old concepts,
like checking versions, which should be cleaned. This PR fixes the
versions and cleans out the old concepts.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#610

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 11, 2021
The versions in packages/osd-plugin-helpers/README.md are still 6.3
which should be updated to 1.0. Meanwhile, there are some old concepts,
like checking versions, which should be cleaned. This PR fixes the
versions and cleans out the old concepts.

Partically Resolved:
#592

Backport PR:
#610

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 11, 2021
The versions in packages/osd-plugin-helpers/README.md are still 6.3
which should be updated to 1.0. Meanwhile, there are some old concepts,
like checking versions, which should be cleaned. This PR fixes the
versions and cleans out the old concepts.

Partically Resolved:
#592

Backport PR:
#610

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh deleted the fix_osd_plugin_helpers branch February 23, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants