[Manual][Backport 2.x]Add sidecar service (#5920) #6157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: sidecar poc Signed-off-by: tygao <tygao@amazon.com> * update sidecar Signed-off-by: tygao <tygao@amazon.com> * update mouseevent Signed-off-by: tygao <tygao@amazon.com> * update type Signed-off-by: tygao <tygao@amazon.com> * update service mock Signed-off-by: tygao <tygao@amazon.com> * update sidecar config mode type Signed-off-by: tygao <tygao@amazon.com> * update docked mode enum Signed-off-by: tygao <tygao@amazon.com> * update resizable button style Signed-off-by: tygao <tygao@amazon.com> * doc: add changelog Signed-off-by: tygao <tygao@amazon.com> * test: update snapshots Signed-off-by: tygao <tygao@amazon.com> * fix typo Signed-off-by: tygao <tygao@amazon.com> * doc: update readme Signed-off-by: tygao <tygao@amazon.com> * test: add test for resizable button and service Signed-off-by: tygao <tygao@amazon.com> * test: add test for create react overlays and app container Signed-off-by: tygao <tygao@amazon.com> * test: add tests for service and components Signed-off-by: tygao <tygao@amazon.com> * test: update tests for resizable button Signed-off-by: tygao <tygao@amazon.com> * fix: update enum usage Signed-off-by: tygao <tygao@amazon.com> * update Signed-off-by: tygao <tygao@amazon.com> * fix wrong change Signed-off-by: tygao <tygao@amazon.com> * add prefix for resizableButton Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> (cherry picked from commit c2c4f53)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6157 +/- ##
==========================================
+ Coverage 67.11% 67.15% +0.03%
==========================================
Files 3316 3321 +5
Lines 64093 64198 +105
Branches 10241 10257 +16
==========================================
+ Hits 43019 43115 +96
- Misses 18582 18589 +7
- Partials 2492 2494 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe and
ruanyl
as code owners
|
@raintygao We may need backport the |
As i see other backport PRs to 2.x, they all remove changelog changes, and there is also no features part content in changelog of 2.x branch. |
SuZhou-Joe
approved these changes
Mar 18, 2024
Confused too, so I will keep consistent with other backport PRs to 2.x for now. |
ruanyl
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherry pick of c2c4f53 from #5920