-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manual][Backport 2.x] Improves connection pooling support for AWSSigV4 clients in data sources (#6135) #6176
[Manual][Backport 2.x] Improves connection pooling support for AWSSigV4 clients in data sources (#6135) #6176
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6176 +/- ##
=======================================
Coverage 67.17% 67.17%
=======================================
Files 3330 3331 +1
Lines 64313 64387 +74
Branches 10273 10281 +8
=======================================
+ Hits 43204 43254 +50
- Misses 18608 18636 +28
+ Partials 2501 2497 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Before rebase all CIs have been passed except WhiteSource Security check (which is expected). |
5474104
to
f363300
Compare
As per @AMoo-Miki, did testing for Node 14. Working as expected. Adding more details in PR Overview. |
…rces. (opensearch-project#6135) * Upgrade @opensearch/opensearch@2.6.0 which inherits AWSSigv4 to .child Signed-off-by: Bandini Bhopi <bandinib@amazon.com> * Uses client.child for aws sigv4 connection Signed-off-by: Bandini Bhopi <bandinib@amazon.com> * Import http-aws-es connector class Signed-off-by: Bandini Bhopi <bandinib@amazon.com> * Refactor client caching mechanism Signed-off-by: Bandini Bhopi <bandinib@amazon.com> * Fix UT Signed-off-by: Bandini Bhopi <bandinib@amazon.com> * Added UT for client pool Signed-off-by: Bandini Bhopi <bandinib@amazon.com> * Revert client pool changes from authentication method Signed-off-by: Bandini Bhopi <bandinib@amazon.com> --------- Signed-off-by: Bandini Bhopi <bandinib@amazon.com> (cherry picked from commit 09f5563)
f363300
to
5edb124
Compare
bootstrap somehow failed on ciGroup1, maybe wait for retry |
All checks are successful except WhiteSource Security checks (which is expected). |
Overview
This is cherry pick of 1999a23 from #6135
Testing
Testing with Node 14.
After creating data sources, following scenarios tested: