Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0][Bug] Remove appKey in github-checks-reporter #620

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jul 9, 2021

Description

github-checks-reporter is a task wrapper that provides expressive
CI feedback via GitHub checks. Currently, we don’t have our own
appKey. To avoid any confusions, this PR removed the old key.

Partically Resolved:

#592

Backport PR:

#603

Signed-off-by: Anan Zhuang ananzh@amazon.com

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

github-checks-reporter is a task wrapper that provides expressive
CI feedback via GitHub checks. Currently, we don’t have our own
appKey. To avoid any confusions, this PR removed the old key.

Partically Resolved:
opensearch-project#592

Backport PR:
opensearch-project#603

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh added bug Something isn't working v1.0.0 backport labels Jul 9, 2021
@ananzh ananzh requested a review from kavilla July 9, 2021 18:47
@ananzh ananzh self-assigned this Jul 9, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed dd7e25e

@ananzh ananzh merged commit d0b9413 into opensearch-project:1.0 Jul 11, 2021
@ananzh ananzh deleted the 1.0_fix_checks_reporter branch July 11, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants