Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [osd/std] Add additional recovery from false-positives in handling of long numerals #6246

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 902e216 from #6245.

… long numerals (#6245)

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 902e216)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.26%. Comparing base (fcf1dbb) to head (fb2aa78).

Files Patch % Lines
packages/osd-std/src/json.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #6246   +/-   ##
=======================================
  Coverage   67.26%   67.26%           
=======================================
  Files        3335     3335           
  Lines       64580    64580           
  Branches    10327    10327           
=======================================
  Hits        43441    43441           
  Misses      18635    18635           
  Partials     2504     2504           
Flag Coverage Δ
Linux_1 31.30% <0.00%> (ø)
Linux_2 55.39% <50.00%> (ø)
Linux_3 44.69% <0.00%> (-0.02%) ⬇️
Linux_4 35.31% <0.00%> (ø)
Windows_1 31.33% <0.00%> (ø)
Windows_2 55.35% <50.00%> (ø)
Windows_3 44.69% <0.00%> (-0.02%) ⬇️
Windows_4 35.31% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki
Copy link
Collaborator

ci:9 failure is related to CSP overlay and unrelated to this change.

@AMoo-Miki AMoo-Miki merged commit 1bdaecd into 2.x Mar 23, 2024
88 of 90 checks passed
@github-actions github-actions bot deleted the backport/backport-6245-to-2.x branch March 23, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.13.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants