[Backport 2.x] [Multiple DataSource]Add datasource query for DataSourceView component to add label when only pass id #6332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…t to add label when only pass id (#6315) * Add datasource query for DataSourceView component to add label when only pass id Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * update changelog Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * fix the failed test Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * fix comment Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * extract interface Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * revert yml Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * add more test Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * update snapshot Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * update snpshot Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * update change log Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * update change log and address other comments Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> * Update CHANGELOG.md Co-authored-by: Lu Yu <nluyu@amazon.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com> * Update src/plugins/data_source_management/public/components/data_source_menu/data_source_menu.tsx Co-authored-by: Lu Yu <nluyu@amazon.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com> --------- Signed-off-by: yujin-emma <yujin.emma.work@gmail.com> Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com> Co-authored-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit cf43af3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
added
multiple datasource
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6332 +/- ##
==========================================
- Coverage 67.33% 67.33% -0.01%
==========================================
Files 3344 3344
Lines 64820 64835 +15
Branches 10384 10386 +2
==========================================
+ Hits 43646 43656 +10
- Misses 18648 18652 +4
- Partials 2526 2527 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BionIT
approved these changes
Apr 3, 2024
ZilongX
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport cf43af3 from #6315.