Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MD] Add OpenSearch cluster group label to top of single selectable dropdown #6400

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[MD] Add OpenSearch cluster group label to top of single selectable dropdown #6400

merged 1 commit into from
Apr 11, 2024

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Apr 10, 2024 •
edited
Loading

Description

  • when there's options available, add OpenSearch cluster group label to the top of options in DataSourceSelectable dropdown.
    image
  • when there's no options, don't render the opensearch cluster group label
    image
iShot_2024-04-10_15.10.09.mp4

Issues Resolved

part of #6370

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@zhongnansu zhongnansu added multiple datasource multiple datasource project v2.14.0 and removed all-star-contributor labels Apr 10, 2024
@zhongnansu zhongnansu marked this pull request as ready for review April 10, 2024 22:27
@zhongnansu
[MD] Add OpenSearch cluster group label to top of options in DataSour…
5550065 
…ceSelectable dropdown

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@zhongnansu zhongnansu force-pushed the add-group-label-to-selectable branch from 4e8e396 to 5550065 Compare April 10, 2024 22:30
@zhongnansu zhongnansu merged commit 7e1d940 into opensearch-project:main Apr 11, 2024
69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 11, 2024
@github-actions
[MD] Add OpenSearch cluster group label to top of options in DataSour…
5e41167 
…ceSelectable dropdown (#6400)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit 7e1d940)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 11, 2024
Merged
ananzh pushed a commit that referenced this pull request Apr 12, 2024
@opensearch-trigger-bot @github-actions
[MD] Add OpenSearch cluster group label to top of options in DataSour…
fb86f6b 
…ceSelectable dropdown (#6400) (#6401)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit 7e1d940)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Apr 22, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZilongX ZilongX ZilongX approved these changes

@BionIT BionIT BionIT approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

Assignees
No one assigned
Labels
backport 2.x multiple datasource multiple datasource project v2.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhongnansu @BionIT @ZilongX