-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Dashboard admin(groups/users) implementation #6554
Merged
SuZhou-Joe
merged 37 commits into
opensearch-project:main
from
yubonluo:main-admin-back
May 24, 2024
Merged
[Workspace] Dashboard admin(groups/users) implementation #6554
SuZhou-Joe
merged 37 commits into
opensearch-project:main
from
yubonluo:main-admin-back
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing with dynamic application config Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
April 19, 2024 07:27
Signed-off-by: yubonluo <yubonluo@amazon.com>
…boards into main-admin-back
Signed-off-by: yubonluo <yubonluo@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6554 +/- ##
==========================================
+ Coverage 67.36% 67.38% +0.01%
==========================================
Files 3443 3443
Lines 67762 67788 +26
Branches 11024 11031 +7
==========================================
+ Hits 45651 45679 +28
+ Misses 19440 19439 -1
+ Partials 2671 2670 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
reviewed
May 17, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
reviewed
May 20, 2024
SuZhou-Joe
previously approved these changes
May 20, 2024
…oards into main-admin-back
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into main-admin-back
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
previously approved these changes
May 23, 2024
…oards into main-admin-back
Signed-off-by: yubonluo <yubonluo@amazon.com>
…boards into main-admin-back
SuZhou-Joe
reviewed
May 24, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into main-admin-back
ruanyl
approved these changes
May 24, 2024
SuZhou-Joe
approved these changes
May 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 24, 2024
* [Workspace] dashboard admin(groups/users) implementation and integrating with dynamic application config Signed-off-by: yubonluo <yubonluo@amazon.com> * Modify change log Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * modify change log Signed-off-by: yubonluo <yubonluo@amazon.com> * modify change log Signed-off-by: yubonluo <yubonluo@amazon.com> * solve change log issue Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #6554 created/updated * [Workspace] delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #6554 created/updated * delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * Optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * Add unit test to cover setupPermission in plugin. Signed-off-by: yubonluo <yubonluo@amazon.com> * delete the logic of dynamic application config Signed-off-by: yubonluo <yubonluo@amazon.com> * Default to OSD admin if security uninstall Signed-off-by: yubonluo <yubonluo@amazon.com> * Default to OSD admin if security uninstall Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b839da1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
May 27, 2024
* [Workspace] dashboard admin(groups/users) implementation and integrating with dynamic application config * Modify change log * optimize the code * modify change log * modify change log * solve change log issue * Changeset file for PR #6554 created/updated * [Workspace] delete useless code * Changeset file for PR #6554 created/updated * delete useless code * Optimize the code * Add unit test to cover setupPermission in plugin. * delete the logic of dynamic application config * Default to OSD admin if security uninstall * Default to OSD admin if security uninstall --------- (cherry picked from commit b839da1) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
…project#6554) * [Workspace] dashboard admin(groups/users) implementation and integrating with dynamic application config Signed-off-by: yubonluo <yubonluo@amazon.com> * Modify change log Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * modify change log Signed-off-by: yubonluo <yubonluo@amazon.com> * modify change log Signed-off-by: yubonluo <yubonluo@amazon.com> * solve change log issue Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR opensearch-project#6554 created/updated * [Workspace] delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR opensearch-project#6554 created/updated * delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * Optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * Add unit test to cover setupPermission in plugin. Signed-off-by: yubonluo <yubonluo@amazon.com> * delete the logic of dynamic application config Signed-off-by: yubonluo <yubonluo@amazon.com> * Default to OSD admin if security uninstall Signed-off-by: yubonluo <yubonluo@amazon.com> * Default to OSD admin if security uninstall Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR set the backend roles in groups or users, whoever has the backend roles or exactly match the user or groups ids defined in this yml.config/dynamic config will be regard as dashboard admin.
Dashboard admin will have the access to all the workspaces and objects inside OpenSearch Dashboards.
Issues Resolved
#6389
Changelog
Screenshot
No UI change in this PR.
Testing the changes
Yml config test
git apply ./test.patch
config/opensearch_dashboards.yml
yarn start --no-base-path
and visit http://localhost:5601Check List
yarn test:jest
yarn test:jest_integration