Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Data selector enhancement #6571

Merged
merged 26 commits into from
Apr 30, 2024

fix one test

c8753d9
Select commit
Loading
Failed to load commit list.
Merged

[Discover] Data selector enhancement #6571

fix one test
c8753d9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 30, 2024 in 0s

67.74% (+0.00%) compared to cfe7cd1

View this Pull Request on Codecov

67.74% (+0.00%) compared to cfe7cd1

Details

Codecov Report

Attention: Patch coverage is 72.63158% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 67.74%. Comparing base (cfe7cd1) to head (c8753d9).
Report is 2 commits behind head on main.

Files Patch % Lines
..._sources/datasource_services/datasource_service.ts 59.25% 9 Missing and 2 partials ⚠️
...rces/datasource_selector/datasource_selectable.tsx 78.78% 3 Missing and 4 partials ⚠️
src/plugins/data/public/plugin.ts 0.00% 4 Missing ⚠️
...lugins/discover/public/__mock__/index.test.mock.ts 25.00% 3 Missing ⚠️
.../data_explorer/public/components/sidebar/index.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6571   +/-   ##
=======================================
  Coverage   67.73%   67.74%           
=======================================
  Files        3415     3417    +2     
  Lines       66851    66887   +36     
  Branches    10874    10878    +4     
=======================================
+ Hits        45282    45312   +30     
- Misses      18923    18926    +3     
- Partials     2646     2649    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov