[Workspace] Make dashboards management available #6575

yubonluo · 2024-04-22T02:52:39Z

Description

User can choose the feature of Dashboards Management when user create/update a workspace.

Issues Resolved

#6574

Screenshot

Testing the changes

Clone the latest code and run yarn osd bootstrap
Modify config/opensearch_dashboards.yml, add workspace.enabled: true
Run yarn start --no-base-path
Create a workspace choose the feature of Dashboard Management

Changelog

feat: [Workspace] Make dashboards management available

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: yubonluo <yubonluo@amazon.com>

src/plugins/workspace/public/utils.ts

Signed-off-by: yubonluo <yubonluo@amazon.com>

Hailong-am · 2024-04-22T03:36:47Z

src/plugins/workspace/opensearch_dashboards.json

@@ -5,8 +5,9 @@
  "ui": true,
  "requiredPlugins": [
    "savedObjects",
-    "opensearchDashboardsReact"
+    "opensearchDashboardsReact",
+    "management"


any reason move it to requiredPlugins?

There is a reference in the code: import { MANAGEMENT_APP_ID } from '../../management/public';

I think adding it as require_bundles is good enough.

If management is not in required bundles, CI will fail.

Forget it, it seems requiredBundles has some impact on bundling lifeCycle. Then let's revert to hard-coded version then, sorry for the back-and-forth.

It's not a matter, the code has been reverted.

Hailong-am · 2024-04-22T03:38:46Z

src/plugins/workspace/public/utils.ts

+    if (category?.id === DEFAULT_APP_CATEGORIES.management.id) {
+      return filterCondition && id === MANAGEMENT_APP_ID;
+    }
+    return filterCondition;


can we add more comments of why we would like add an exception case for management

Yes, the comments has been added.

Signed-off-by: yubonluo <yubonluo@amazon.com>

…earch-Dashboards into main-management-available

Signed-off-by: yubonluo <yubonluo@amazon.com>

* [Workspace] Make dashboards management available Signed-off-by: yubonluo <yubonluo@amazon.com> * [Workspace] optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * [Workspace] optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * [Workspace] modify requiredPlugins Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #6575 created/updated * [Workspace] add more comments Signed-off-by: yubonluo <yubonluo@amazon.com> * [Workspace] delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * [Workspace] delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 8db9688) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [Workspace] Make dashboards management available * [Workspace] optimize the code * [Workspace] optimize the code * [Workspace] modify requiredPlugins * Changeset file for PR #6575 created/updated * [Workspace] add more comments * [Workspace] delete useless code * [Workspace] delete useless code --------- (cherry picked from commit 8db9688) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…6575) * [Workspace] Make dashboards management available Signed-off-by: yubonluo <yubonluo@amazon.com> * [Workspace] optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * [Workspace] optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * [Workspace] modify requiredPlugins Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR opensearch-project#6575 created/updated * [Workspace] add more comments Signed-off-by: yubonluo <yubonluo@amazon.com> * [Workspace] delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * [Workspace] delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

[Workspace] Make dashboards management available

26572d4

Signed-off-by: yubonluo <yubonluo@amazon.com>

yubonluo requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT and xinruiba as code owners April 22, 2024 02:52

github-actions bot added first-time-contributor failed changeset labels Apr 22, 2024

SuZhou-Joe reviewed Apr 22, 2024

View reviewed changes

src/plugins/workspace/public/utils.ts Show resolved Hide resolved

opensearch-project deleted a comment from github-actions bot Apr 22, 2024

yubonluo and others added 4 commits April 22, 2024 11:05

[Workspace] optimize the code

84801c7

Signed-off-by: yubonluo <yubonluo@amazon.com>

[Workspace] optimize the code

b3a8937

Signed-off-by: yubonluo <yubonluo@amazon.com>

[Workspace] modify requiredPlugins

5403a3b

Signed-off-by: yubonluo <yubonluo@amazon.com>

Changeset file for PR opensearch-project#6575 created/updated

b7ec40b

github-actions bot removed the failed changeset label Apr 22, 2024

Hailong-am reviewed Apr 22, 2024

View reviewed changes

[Workspace] add more comments

5102cba

Signed-off-by: yubonluo <yubonluo@amazon.com>

yubonluo added 3 commits April 22, 2024 11:56

Merge branch 'main-management-available' of github.com:yubonluo/OpenS…

1423a7a

…earch-Dashboards into main-management-available

[Workspace] delete useless code

52c1c1d

Signed-off-by: yubonluo <yubonluo@amazon.com>

[Workspace] delete useless code

8f047b9

Signed-off-by: yubonluo <yubonluo@amazon.com>

SuZhou-Joe approved these changes Apr 22, 2024

View reviewed changes

Hailong-am approved these changes Apr 22, 2024

View reviewed changes

ruanyl approved these changes Apr 22, 2024

View reviewed changes

SuZhou-Joe added the workspace label Apr 22, 2024

SuZhou-Joe merged commit 8db9688 into opensearch-project:main Apr 22, 2024
67 checks passed

SuZhou-Joe added backport 2.x v2.14.0 labels Apr 23, 2024

opensearch-trigger-bot bot mentioned this pull request Apr 23, 2024

[Backport 2.x] [Workspace] Make dashboards management available #6612

Merged

AMoo-Miki added the in-next label Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace] Make dashboards management available #6575

[Workspace] Make dashboards management available #6575

yubonluo commented Apr 22, 2024 •

edited by SuZhou-Joe

Loading

Hailong-am Apr 22, 2024

yubonluo Apr 22, 2024 •

edited

Loading

SuZhou-Joe Apr 22, 2024

yubonluo Apr 22, 2024 •

edited

Loading

SuZhou-Joe Apr 22, 2024 •

edited

Loading

yubonluo Apr 22, 2024

Hailong-am Apr 22, 2024

yubonluo Apr 22, 2024

[Workspace] Make dashboards management available #6575

[Workspace] Make dashboards management available #6575

Conversation

yubonluo commented Apr 22, 2024 • edited by SuZhou-Joe Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

Hailong-am Apr 22, 2024

Choose a reason for hiding this comment

yubonluo Apr 22, 2024 • edited Loading

Choose a reason for hiding this comment

SuZhou-Joe Apr 22, 2024

Choose a reason for hiding this comment

yubonluo Apr 22, 2024 • edited Loading

Choose a reason for hiding this comment

SuZhou-Joe Apr 22, 2024 • edited Loading

Choose a reason for hiding this comment

yubonluo Apr 22, 2024

Choose a reason for hiding this comment

Hailong-am Apr 22, 2024

Choose a reason for hiding this comment

yubonluo Apr 22, 2024

Choose a reason for hiding this comment

yubonluo commented Apr 22, 2024 •

edited by SuZhou-Joe

Loading

yubonluo Apr 22, 2024 •

edited

Loading

yubonluo Apr 22, 2024 •

edited

Loading

SuZhou-Joe Apr 22, 2024 •

edited

Loading