Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace] Hide dashboard overview #6625

Merged
merged 3 commits into from
Apr 24, 2024
Merged

[Workspace] Hide dashboard overview #6625

merged 3 commits into from
Apr 24, 2024

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Apr 24, 2024 •
edited by SuZhou-Joe
Loading

Description

User can not choose the feature of dashboard overview when create/update a workspace.

Issues Resolved

closes #6624

Screenshot

image

Testing the changes

  1. Clone the latest code and run yarn osd bootstrap
  2. Modify config/opensearch_dashboards.yml, add workspace.enabled: true
  3. Run yarn start --no-base-path
  4. Create/update a workspace

Changelog

  • feat: [Workspace] Hide dashboard overview

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yubonluo
feat: hide dashboard overview
157e8df 
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
SuZhou-Joe previously approved these changes Apr 24, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Apr 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.71%. Comparing base (d2d410b) to head (3f4280f).
Report is 508 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #6625       +/-   ##
===========================================
+ Coverage   32.93%   67.71%   +34.78%     
===========================================
  Files        2260     3403     +1143     
  Lines       45769    66609    +20840     
  Branches     7200    10827     +3627     
===========================================
+ Hits        15075    45107    +30032     
+ Misses      29984    18862    -11122     
- Partials      710     2640     +1930
Flag Coverage Δ
Linux_1 33.05% <100.00%> (+0.11%) ⬆️
Linux_2 55.60% <ø> (?)
Linux_3 45.21% <ø> (?)
Linux_4 34.92% <ø> (?)
Windows_1 33.07% <100.00%> (?)
Windows_2 55.57% <ø> (?)
Windows_3 45.22% <ø> (?)
Windows_4 34.92% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 17ce314 into opensearch-project:main Apr 24, 2024
69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2024
@github-actions @opensearch-changeset-bot
[Workspace] Hide dashboard overview (#6625)
66f2792 
* feat: hide dashboard overview

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #6625 created/updated

* Changeset file for PR #6625 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 17ce314)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 25, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Apr 25, 2024
@github-actions @opensearch-changeset-bot @SuZhou-Joe
[Workspace] Hide dashboard overview (#6625)
cf8f988 
* feat: hide dashboard overview

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #6625 created/updated

* Changeset file for PR #6625 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 17ce314)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Apr 25, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Workspace] Hide dashboard overview (#6625) (#6633)
edb0d1c 
* feat: hide dashboard overview



* Changeset file for PR #6625 created/updated

* Changeset file for PR #6625 created/updated

---------



(cherry picked from commit 17ce314)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jun 3, 2024
@yubonluo @opensearch-changeset-bot @LDrago27
[Workspace] Hide dashboard overview (opensearch-project#6625)
b022ec2 
* feat: hide dashboard overview

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR opensearch-project#6625 created/updated

* Changeset file for PR opensearch-project#6625 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

Assignees
No one assigned
Labels
backport 2.x in-next repeat-contributor v2.14.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Workspace] Hide dashboard overview feature
4 participants
@yubonluo @ruanyl @SuZhou-Joe @AMoo-Miki