fix (startup): fix font theme key #6703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuarrrr
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
github-actions
bot
added
distinguished-contributor
Skip-Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6703 +/- ##
=======================================
Coverage 67.70% 67.70%
=======================================
Files 3417 3417
Lines 66922 66922
Branches 10888 10888
=======================================
Hits 45310 45310
Misses 18966 18966
Partials 2646 2646
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joshuarrrr
force-pushed
the
fix/next-theme-font-key
branch
from
0764320 to
74782b2
Compare
key should be `v8` not `default` Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
force-pushed
the
fix/next-theme-font-key
branch
from
74782b2 to
f9b2328
Compare
kavilla
approved these changes
May 2, 2024
|
we might need to figure out how to test effectively and ensure a way to automate regression test. considering it is blocking 2.14, could we merge and test manually? |
seraphjiang
approved these changes
May 2, 2024
|
Want to understand better, is this a bug fix? If yes, what was the issue and how do we know it is fixed? |
|
Approve to unblock release, but we need more details |
BionIT
approved these changes
May 2, 2024
Yeah we felt the same: However, haven't had the bandwidth. |
Flyingliuhub
approved these changes
May 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
key should be `v8` not `default` Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 1029884) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
key should be `v8` not `default` Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 1029884) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
May 2, 2024
key should be `v8` not `default` (cherry picked from commit 1029884) Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
May 3, 2024
key should be `v8` not `default` (cherry picked from commit 1029884) Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this pull request
May 7, 2024
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
key should be `v8` not `default` Signed-off-by: Josh Romero <rmerqg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
undefinedvalue in font family for next theme. The key should bev8notdefault. Skipping changelog entry as this is a follow-up fix to #5652, which hasn't yet been released.Issues Resolved
Screenshot
Before:
After:
Testing the changes
Validated locally. Reviewers can test by inspecting the generated
/startup.jsfile when using the next theme and validating that the font-family starts withSource Sans 3, notundefined.Changelog
Check List
yarn test:jestyarn test:jest_integration