-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Server Side batching for UI Metric Collectors #6721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDrago27
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
May 6, 2024 17:44
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
opensearch-changeset-bot bot
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
May 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6721 +/- ##
==========================================
- Coverage 67.72% 67.57% -0.15%
==========================================
Files 3415 3428 +13
Lines 66886 67343 +457
Branches 10884 10996 +112
==========================================
+ Hits 45297 45508 +211
- Misses 18943 19165 +222
- Partials 2646 2670 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LDrago27
force-pushed
the
serverSideBatching
branch
2 times, most recently
from
May 7, 2024 00:07
b661d78
to
07294e6
Compare
Merged
1 task
kavilla
reviewed
May 7, 2024
LDrago27
force-pushed
the
serverSideBatching
branch
from
May 7, 2024 19:58
9e56ca1
to
364f2a0
Compare
kavilla
reviewed
May 8, 2024
kavilla
reviewed
May 8, 2024
kavilla
reviewed
May 8, 2024
kavilla
reviewed
May 8, 2024
kavilla
reviewed
May 8, 2024
LDrago27
force-pushed
the
serverSideBatching
branch
from
May 8, 2024 17:38
364f2a0
to
18adcfc
Compare
kavilla
previously approved these changes
May 13, 2024
AMoo-Miki
reviewed
May 14, 2024
AMoo-Miki
reviewed
May 14, 2024
LDrago27
force-pushed
the
serverSideBatching
branch
from
May 14, 2024 21:32
18adcfc
to
bf467c5
Compare
AMoo-Miki
requested changes
May 14, 2024
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
LDrago27
force-pushed
the
serverSideBatching
branch
from
May 17, 2024 19:20
bf467c5
to
1f9f140
Compare
AMoo-Miki
approved these changes
May 21, 2024
kavilla
approved these changes
May 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 22, 2024
* Add Server Side batching for UI Metric Collectors Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR #6721 created/updated This PR introduces Server Side batching of UI metric reports sent by clients to reduce the number of updates taking place at OpenSearch. Issues Resolved #6375 --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 972cf10) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
May 23, 2024
* Add Server Side batching for UI Metric Collectors * Changeset file for PR #6721 created/updated This PR introduces Server Side batching of UI metric reports sent by clients to reduce the number of updates taking place at OpenSearch. Issues Resolved #6375 --------- (cherry picked from commit 972cf10) Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
…#6721) * Add Server Side batching for UI Metric Collectors Signed-off-by: Suchit Sahoo <suchsah@amazon.com> * Changeset file for PR opensearch-project#6721 created/updated This PR introduces Server Side batching of UI metric reports sent by clients to reduce the number of updates taking place at OpenSearch. Issues Resolved opensearch-project#6375 --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces Server Side batching of UI metric reports sent by clients to reduce the number of updates taking place at OpenSearch.
Issues Resolved
#6375
Testing the changes
/api/stats?extended=true&legacy=true&exclude_usage=false
/api/ui_metric/report
with the following request body{"report":{"reportVersion":1,"uiStatsMetrics":{"console-count-GET_cat.indices":{"key":"console-count-GET_cat.indices","appName":"console","eventName":"GET_cat.indices","type":"count","stats":{"min":0,"max":1,"avg":0.5,"sum":21}}}}}
/api/stats?extended=true&legacy=true&exclude_usage=false
and verify that it has an entry{"key":"GET_cat.indices","value":21}
/api/ui_metric/report
with the following request body{"report":{"reportVersion":1,"uiStatsMetrics":{"console-count-GET_cat.indices":{"key":"console-count-GET_cat.indices","appName":"console","eventName":"GET_cat.indices","type":"count","stats":{"min":0,"max":1,"avg":0.5,"sum":21}}}}}
/api/stats?extended=true&legacy=true&exclude_usage=false
and verify that it has an entry{"key":"GET_cat.indices","value":21}
the count shouldn't have been updated/api/ui_metric/report
with the following request body{"report":{"reportVersion":1,"uiStatsMetrics":{"console-count-GET_cat.indices":{"key":"console-count-GET_cat.indices","appName":"console","eventName":"GET_cat.indices","type":"count","stats":{"min":0,"max":1,"avg":0.5,"sum":21}}}}}
/api/stats?extended=true&legacy=true&exclude_usage=false
and verify that it has an entry{"key":"GET_cat.indices","value":63}
the count should be updated to the latest valueOR
You can pull in changes opensearch-project/opensearch-dashboards-functional-test#1267 update the flag
"UIMETRIC_ENABLED": true
and run the following commandyarn cypress run --spec cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/telemetry/server.spec.js
. This test automates the above mentioned steps.Changelog
Check List
yarn test:jest
yarn test:jest_integration