Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVE-2024-33883] Bump ejs from 3.1.7 to 3.1.10 #6770

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented May 10, 2024

Issue Resolved

#6769

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.12%. Comparing base (8d50974) to head (02a3799).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6770       +/-   ##
===========================================
- Coverage   67.38%   55.12%   -12.27%     
===========================================
  Files        3443     1204     -2239     
  Lines       67795    24625    -43170     
  Branches    11032     4168     -6864     
===========================================
- Hits        45683    13574    -32109     
+ Misses      19440    10400     -9040     
+ Partials     2672      651     -2021     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.12% <ø> (ø)
Linux_3 ?
Linux_4 ?
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as 3.1.101 doesn't seem to exist and lint errors seem unrelated...

@@ -11,7 +11,7 @@
"dependencies": {
"@osd/cross-platform": "1.0.0",
"@osd/dev-utils": "1.0.0",
"ejs": "^3.1.7",
"ejs": "^3.1.10",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the title should be update to 3.1.10 instead of 3.1.101?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 1 should be `. Will correct it and thank you for the careful check.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change to accurate version

@@ -0,0 +1,2 @@
security:
- [CVE-2024-33883] Bump ejs from `3.1.7` to `3.1.101 ([#6770](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6770))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 3.1.10?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 1 should be `. Will correct it and thank you for the careful check.

@@ -11,7 +11,7 @@
"dependencies": {
"@osd/cross-platform": "1.0.0",
"@osd/dev-utils": "1.0.0",
"ejs": "^3.1.7",
"ejs": "^3.1.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ananzh ananzh changed the title [CVE-2024-33883] Bump ejs from 3.1.7 to `3.1.101 [CVE-2024-33883] Bump ejs from 3.1.7 to 3.1.101 Jun 3, 2024
@ananzh ananzh changed the title [CVE-2024-33883] Bump ejs from 3.1.7 to 3.1.101 [CVE-2024-33883] Bump ejs from 3.1.7 to 3.1.10 Jun 3, 2024
@ananzh
Copy link
Member Author

ananzh commented Jun 3, 2024

@bandinib-amzn @virajsanghvi I corrected the typo. Could you two help me to re-check this fix?

@ananzh ananzh added cve Security vulnerabilities detected by Dependabot or Mend backport 2.x v2.15.0 labels Jun 4, 2024
@ananzh ananzh merged commit 016dcfd into opensearch-project:main Jun 4, 2024
72 of 73 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6770-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 016dcfd82bb93ca3e64d4eaf54d9a34795c02891
# Push it to GitHub
git push --set-upstream origin backport/backport-6770-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6770-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6770-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 016dcfd82bb93ca3e64d4eaf54d9a34795c02891
# Push it to GitHub
git push --set-upstream origin backport/backport-6770-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6770-to-2.x.

ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jun 5, 2024
Backport PR
opensearch-project#6770

Issue Resolved
opensearch-project#6769

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
BionIT pushed a commit that referenced this pull request Jun 5, 2024
…6924)

Backport PR
#6770

Issue Resolved
#6769

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@BionIT
Copy link
Collaborator

BionIT commented Jun 5, 2024

Thanks @ananzh ! Found we have a manual backport #6924, thus removed the failed backport label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x cve Security vulnerabilities detected by Dependabot or Mend distinguished-contributor v2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants