fix for quickrange to use datemath to parse datetime strings #6782

paulstn · 2024-05-13T23:11:10Z

Description

provides a formatting util function meant to convert quick range time (such as 'now-15m') to datetimes that can be understood.
related to: kavilla/qlDashboards#4

Issues Resolved

Screenshot

Testing the changes

Changelog

fix: Quickrange selection fix

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

github-actions · 2024-05-13T23:11:44Z

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 6782.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

github-actions · 2024-05-13T23:24:56Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

codecov · 2024-05-13T23:25:57Z

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.35%. Comparing base (972cf10) to head (adaf17e).
Report is 3 commits behind head on main.

Files	Patch %	Lines
src/plugins/data/common/data_frames/utils.ts	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6782      +/-   ##
==========================================
- Coverage   67.56%   67.35%   -0.21%     
==========================================
  Files        3428     3443      +15     
  Lines       67343    67795     +452     
  Branches    10996    11032      +36     
==========================================
+ Hits        45498    45666     +168     
- Misses      19176    19434     +258     
- Partials     2669     2695      +26

Flag	Coverage Δ
Linux_1	`33.07% <14.28%> (+0.02%)`	⬆️
Linux_2	`?`
Linux_3	`?`
Linux_4	`?`
Windows_1	`33.12% <14.28%> (+0.05%)`	⬆️
Windows_2	`55.09% <14.28%> (-0.02%)`	⬇️
Windows_3	`45.19% <85.71%> (+0.01%)`	⬆️
Windows_4	`34.81% <14.28%> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/plugins/data/common/data_frames/utils.ts

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

paulstn · 2024-05-23T21:19:00Z

src/plugins/data/common/data_frames/data_frame_utils.test.ts

+
+describe('Data Frame Utils', () => {
+  describe('formatTimePickerDate function', () => {
+    Date.now = jest.fn(() => new Date('2024-05-04T12:30:00.000Z'));


@kavilla is this fine for mocking the time or is there another preferred option?

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

src/plugins/data/common/data_frames/data_frame_utils.test.ts

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

provides a formatting util function meant to convert quick range time (such as 'now-15m') to datetimes that can be understood. Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 347639f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…6868) provides a formatting util function meant to convert quick range time (such as 'now-15m') to datetimes that can be understood. --------- (cherry picked from commit 347639f) Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…rch-project#6782) provides a formatting util function meant to convert quick range time (such as 'now-15m') to datetimes that can be understood. Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…6834) provides a formatting util function meant to convert quick range time (such as 'now-15m') to datetimes that can be understood. --------- (cherry picked from commit 347639f) Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

fix for quickrange to use datemath to parse datetime strings

6b97b82

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

paulstn requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT and xinruiba as code owners May 13, 2024 23:11

github-actions bot added the first-time-contributor label May 13, 2024

github-actions bot added the failed changeset label May 13, 2024

paulstn closed this May 13, 2024

paulstn reopened this May 13, 2024

kavilla reviewed May 14, 2024

View reviewed changes

src/plugins/data/common/data_frames/utils.ts Outdated Show resolved Hide resolved

abbyhu2000 assigned kavilla May 14, 2024

manasvinibs reviewed May 20, 2024

View reviewed changes

src/plugins/data/common/data_frames/utils.ts Outdated Show resolved Hide resolved

Changeset file for PR opensearch-project#6782 created/updated

2624ad0

github-actions bot removed the failed changeset label May 23, 2024

opensearch-changeset-bot bot requested review from zhyuanqi and mengweieric as code owners May 23, 2024 20:26

paulstn added 2 commits May 23, 2024 13:39

turn the formatting string into parameter

4fb844b

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

added testing file

c92f50c

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

paulstn commented May 23, 2024

View reviewed changes

add another test

1ec018a

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

paulstn requested review from kavilla and manasvinibs May 23, 2024 21:25

Merge branch 'main' into discover-ppl-quick-range

de74b46

kavilla reviewed May 24, 2024

View reviewed changes

src/plugins/data/common/data_frames/data_frame_utils.test.ts Show resolved Hide resolved

kavilla reviewed May 24, 2024

View reviewed changes

src/plugins/data/common/data_frames/data_frame_utils.test.ts Outdated Show resolved Hide resolved

update license header

adaf17e

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

paulstn requested a review from kavilla May 24, 2024 19:11

kavilla approved these changes May 24, 2024

View reviewed changes

manasvinibs approved these changes May 24, 2024

View reviewed changes

kavilla merged commit 347639f into opensearch-project:main May 24, 2024
67 checks passed

kavilla added backport 2.x v2.15.0 labels May 24, 2024

opensearch-trigger-bot bot mentioned this pull request May 24, 2024

[Backport 2.x] fix for quickrange to use datemath to parse datetime strings #6834

Merged

paulstn deleted the discover-ppl-quick-range branch May 24, 2024 20:05

kavilla added the backport feature/discover-next label May 30, 2024

opensearch-trigger-bot bot mentioned this pull request May 30, 2024

[Backport feature/discover-next] fix for quickrange to use datemath to parse datetime strings #6868

Merged

ananzh mentioned this pull request Jun 7, 2024

[Meta][2.15 Release] OpenSearch Dashboards Visualization+Discover+CVEs+Maintenance PRs sign-off #6962

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix for quickrange to use datemath to parse datetime strings #6782

fix for quickrange to use datemath to parse datetime strings #6782

paulstn commented May 13, 2024 •

edited

Loading

github-actions bot commented May 13, 2024

github-actions bot commented May 13, 2024

codecov bot commented May 13, 2024 •

edited

Loading

paulstn May 23, 2024

fix for quickrange to use datemath to parse datetime strings #6782

fix for quickrange to use datemath to parse datetime strings #6782

Conversation

paulstn commented May 13, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

github-actions bot commented May 13, 2024

ℹ️ Manual Changeset Creation Reminder

github-actions bot commented May 13, 2024

❌ Empty Changelog Section

codecov bot commented May 13, 2024 • edited Loading

Codecov Report

paulstn May 23, 2024

Choose a reason for hiding this comment

paulstn commented May 13, 2024 •

edited

Loading

codecov bot commented May 13, 2024 •

edited

Loading