-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multi Datasource] Unify getDefaultDataSourceId and export #6843
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6843 +/- ##
==========================================
- Coverage 67.43% 67.41% -0.02%
==========================================
Files 3444 3444
Lines 67834 67839 +5
Branches 11031 11033 +2
==========================================
- Hits 45741 45736 -5
- Misses 19427 19438 +11
+ Partials 2666 2665 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Could we add any tests that have been done for this change? |
Sure, updated. |
How can other plugins use this method? I thought it will be export through data source service. |
Just discussed with @SuZhou-Joe @wanglam offline, we could return these util functions in setup. So that other plugins can use these functions through |
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
* Unify getDefaultDataSourceId and export Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #6843 created/updated * test: add tests for utils Signed-off-by: tygao <tygao@amazon.com> * return utils in setup Signed-off-by: tygao <tygao@amazon.com> * update interface Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit c7c47d2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…h-project#6843) * Unify getDefaultDataSourceId and export Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#6843 created/updated * test: add tests for utils Signed-off-by: tygao <tygao@amazon.com> * return utils in setup Signed-off-by: tygao <tygao@amazon.com> * update interface Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…6882) * Unify getDefaultDataSourceId and export * Changeset file for PR #6843 created/updated * test: add tests for utils * return utils in setup * update interface --------- (cherry picked from commit c7c47d2) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <nluyu@amazon.com>
Description
Context
opensearch-project/dashboards-assistant#191 (comment)
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration