-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Capabilities service add dashboard admin flag #7103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
June 25, 2024 09:34
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7103 +/- ##
=======================================
Coverage 67.49% 67.49%
=======================================
Files 3468 3468
Lines 68363 68366 +3
Branches 11110 11110
=======================================
+ Hits 46140 46143 +3
Misses 19523 19523
Partials 2700 2700
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
reviewed
Jun 25, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
previously approved these changes
Jun 26, 2024
kavilla
reviewed
Jun 26, 2024
kavilla
reviewed
Jun 26, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into 2.16-osd-admin
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into 2.16-osd-admin
ruanyl
reviewed
Jul 2, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
ruanyl
approved these changes
Jul 2, 2024
SuZhou-Joe
approved these changes
Jul 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
* Capabilities service add dashboard admin flag Signed-off-by: yubonluo <yubonluo@amazon.com> * Capabilities service add dashboard admin flag Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #7103 created/updated * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * if groups/users are not configured or [], login defaults to OSD Admin Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit bb9eeef) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 3, 2024
) * Capabilities service add dashboard admin flag * Capabilities service add dashboard admin flag * Changeset file for PR #7103 created/updated * optimize the code * optimize the code * if groups/users are not configured or [], login defaults to OSD Admin * optimize the code --------- (cherry picked from commit bb9eeef) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Capabilities service add dashboard admin flag
Issues Resolved
#7102
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration