[navigation-next]feat: add description field in App. #7152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7152 +/- ##
=======================================
Coverage 67.49% 67.50%
=======================================
Files 3468 3468
Lines 68366 68402 +36
Branches 11110 11117 +7
=======================================
+ Hits 46143 46174 +31
- Misses 19523 19532 +9
+ Partials 2700 2696 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
previously approved these changes
Jul 3, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
ashwin-pc
approved these changes
Jul 4, 2024
ruanyl
approved these changes
Jul 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
* feat: add description in app Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7152 created/updated * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e0945af) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 5, 2024
* feat: add description in app * Changeset file for PR #7152 created/updated * feat: update comment --------- (cherry picked from commit e0945af) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In new overview page, we are showing description of each feature, in that case, we need to add a field
descriptionso that plugins can give the description for their features.Issues Resolved
Screenshot
No UI changes
Testing the changes
Only field change.
Changelog
Check List
yarn test:jestyarn test:jest_integration