Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover-next] (QueryEditorExtensions) change isEnabled to an observable #7183

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Jul 5, 2024

Description

Query Assist feature depends on QueryEditorExtensions and datasource connections service. The change to the currently selected connection will be exposed through an observable (ref), changing isEnabled to an observable makes it easier to update when the selected connection changes.

Issues Resolved

#7034 (comment)

Screenshot

Testing the changes

Changelog

  • feat: [QueryEditorExtensions] change isEnabled to an observable

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Copy link
Contributor

github-actions bot commented Jul 5, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (417246b) to head (195bc0d).
Report is 349 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7183      +/-   ##
==========================================
+ Coverage   67.50%   67.56%   +0.05%     
==========================================
  Files        3468     3469       +1     
  Lines       68402    68479      +77     
  Branches    11117    11130      +13     
==========================================
+ Hits        46174    46266      +92     
+ Misses      19532    19511      -21     
- Partials     2696     2702       +6     
Flag Coverage Δ
Linux_1 33.13% <ø> (+0.08%) ⬆️
Linux_2 55.26% <ø> (+0.04%) ⬆️
Linux_3 45.32% <100.00%> (-0.04%) ⬇️
Linux_4 34.71% <ø> (-0.03%) ⬇️
Windows_1 33.15% <ø> (+0.08%) ⬆️
Windows_2 55.21% <ø> (+0.04%) ⬆️
Windows_3 45.24% <100.00%> (-0.11%) ⬇️
Windows_4 34.71% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuali925 joshuali925 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Jul 5, 2024
ashwin-pc
ashwin-pc previously approved these changes Jul 6, 2024
@github-actions github-actions bot removed the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Jul 8, 2024
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ashwin-pc ashwin-pc merged commit 774f64e into opensearch-project:main Jul 8, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 8, 2024
…able (#7183)

* (QueryEditorExtensions) change isEnabled to an observable

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* rename search bar extension to query editor extension in comments

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Changeset file for PR #7183 created/updated

---------

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 774f64e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla added a commit to kavilla/queryEnhancements that referenced this pull request Jul 8, 2024
…nnection

previously query assist reads the datasource id from the selected index pattern. this PR updates it to read from the new `ConnectionsService`

- fix!: remove dataSource key in get connection response 
   - this is a breaking change on the return response of `GET ${API.DATA_SOURCE.CONNECTIONS}/{dataSourceId}` to be consistent with type
- change isEnabled to an observable based on selected connection 
   - this depends on opensearch-project/OpenSearch-Dashboards#7183, should go in with that PR

Signed-off-by: Joshua Li <joshuali925@gmail.com>
abbyhu2000 pushed a commit that referenced this pull request Jul 22, 2024
…able (#7183) (#7193)

* (QueryEditorExtensions) change isEnabled to an observable



* rename search bar extension to query editor extension in comments



* Changeset file for PR #7183 created/updated

---------



(cherry picked from commit 774f64e)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
…able (opensearch-project#7183) (opensearch-project#7193)

* (QueryEditorExtensions) change isEnabled to an observable



* rename search bar extension to query editor extension in comments



* Changeset file for PR opensearch-project#7183 created/updated

---------



(cherry picked from commit 774f64e)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants