Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Look&Feel] Use small EuiTabs and EuiTabbedContent across the board #7232

Merged
merged 2 commits into from
Jul 16, 2024
Merged

[Look&Feel] Use small EuiTabs and EuiTabbedContent across the board #7232

merged 2 commits into from
Jul 16, 2024

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Jul 12, 2024 •
edited
Loading

Description

Find all usage of EuiTabs and EuiTabbedContent and update them to use size small if not already.

image

Issues Resolved

Screenshot

Testing the changes

Changelog

  • refactor: [Look&Feel] Use small EuiTabs and EuiTabbedContent across the board

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@zhongnansu
[Look&Feel] Use small EuiTabs and EuiTabbedContent across the board
50c6db3 
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.62%. Comparing base (0215e32) to head (2467c2b).
Report is 333 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7232   +/-   ##
=======================================
  Coverage   67.62%   67.62%           
=======================================
  Files        3471     3471           
  Lines       68612    68612           
  Branches    11165    11165           
=======================================
  Hits        46396    46396           
  Misses      19511    19511           
  Partials     2705     2705
Flag Coverage Δ
Linux_1 33.26% <ø> (ø)
Linux_2 55.30% <ø> (ø)
Linux_3 45.26% <ø> (ø)
Linux_4 34.68% <ø> (ø)
Windows_1 33.28% <ø> (ø)
Windows_2 55.25% <ø> (ø)
Windows_3 45.27% <ø> (ø)
Windows_4 34.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@virajsanghvi
Copy link
Collaborator

Approving assuming the checks will pass...

@zhongnansu
Copy link
Member Author

Approving assuming the checks will pass...

Approving assuming the checks will pass...

failed cypress test is related to advanced setting, not related to change in this PR. Also notice same test suite fail in other PRs. https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/9902428483/job/27359262385

@zhongnansu zhongnansu merged commit 9893ce1 into opensearch-project:main Jul 16, 2024
68 of 69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 16, 2024
@github-actions @opensearch-changeset-bot
[Look&Feel] Use small EuiTabs and EuiTabbedContent across the board (#…
d40446e 
…7232)

* [Look&Feel] Use small EuiTabs and EuiTabbedContent across the board

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

* Changeset file for PR #7232 created/updated

---------

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9893ce1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 16, 2024
Merged
zhongnansu pushed a commit that referenced this pull request Jul 18, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Look&Feel] Use small EuiTabs and EuiTabbedContent across the board (#…
e5b6bce 
…7232) (#7255)

* [Look&Feel] Use small EuiTabs and EuiTabbedContent across the board



* Changeset file for PR #7232 created/updated

---------



(cherry picked from commit 9893ce1)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZilongX ZilongX ZilongX approved these changes

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

Assignees
No one assigned
Labels
backport 2.x distinguished-contributor in-next look & feel Look and Feel Improvements v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhongnansu @virajsanghvi @ZilongX @AMoo-Miki