Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation-next] Enable landing page for settings and data administration #7282

Merged
merged 11 commits into from
Jul 19, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Jul 17, 2024

Description

This PR mainly introduces 2 landing pages for 2 system nav group:

  • settings and setup
  • data administration

Issues Resolved

closes #7283

Screenshot

Data administration landing page

image

Settings and setup landing page

image

Testing the changes

  • Goes to advanced settings
  • Enable new home page feature flag and refresh the page
  • Goes to http://localhost:5601/app/settings_landing, you should see landing page for settings and setup.
  • Goes to http://localhost:5601/app/data_administration_landing, you should see landing page for data administration.

Changelog

  • feat: Enable landing page for settings and data administration

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.50%. Comparing base (2c6e78e) to head (ba973b0).

Files Patch % Lines
.../public/components/feature_cards/feature_cards.tsx 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7282   +/-   ##
=======================================
  Coverage   67.50%   67.50%           
=======================================
  Files        3501     3503    +2     
  Lines       69343    69376   +33     
  Branches    11305    11314    +9     
=======================================
+ Hits        46808    46835   +27     
- Misses      19779    19783    +4     
- Partials     2756     2758    +2     
Flag Coverage Δ
Linux_1 33.11% <ø> (ø)
Linux_2 55.46% <ø> (ø)
Linux_3 43.06% <ø> (?)
Linux_4 ?
Windows_1 33.13% <ø> (ø)
Windows_2 55.41% <ø> (ø)
Windows_3 43.06% <ø> (ø)
Windows_4 34.76% <90.90%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe and others added 8 commits July 18, 2024 16:29
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe force-pushed the feature/landing-page branch from 8506b42 to caef5dd Compare July 18, 2024 08:29
@ZilongX
Copy link
Collaborator

ZilongX commented Jul 18, 2024

Pulling the latest main and re-running failed checks

@SuZhou-Joe SuZhou-Joe merged commit e44bd7e into opensearch-project:main Jul 19, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2024
…ation (#7282)

* feat: enable landing page for settings and setup

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: enable landing page for settings and setup

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add page header

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7236 created/updated

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add landing page

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7282 created/updated

* feat: add landing page

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize code

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit e44bd7e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 19, 2024
…ation (#7282) (#7312)

* feat: enable landing page for settings and setup



* feat: enable landing page for settings and setup



* feat: add page header



* Changeset file for PR #7236 created/updated

* feat: update



* feat: add landing page



* Changeset file for PR #7282 created/updated

* feat: add landing page



* feat: optimize code



---------




(cherry picked from commit e44bd7e)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[navigation-next] Add landing pages for system nav group
6 participants