[Manual] [Backport 2.x] [Look&Feel] Replace browser tooltip usage with OUI tooltip #7366

danieldong51 · 2024-07-22T19:52:01Z

Description

Manual backport #7231 to 2.x. Conflicts include:

src/plugins/advanced_settings/public/header_user_theme_menu.tsx due to the file not existing in 2.x (See Revert 815d2bd7c612450e2a15a6543c7e74558adf4a81 "[Manual Backport 2.x] Feat (core): Make theme settings user-specific and user-configurable (#5652) (#6681)" #6978)
src/core/public/chrome/ui/header/home_loader.tsx regarding import Url from 'url' (See [Refactor] Replace url parse format resolve with whatwg url #2910).

Changelog

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2024-07-22T19:52:40Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

codecov · 2024-07-22T20:08:27Z

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.90%. Comparing base (8ee8678) to head (71baf86).

Files	Patch %	Lines
src/core/public/chrome/ui/header/header.tsx	0.00%	1 Missing ⚠️
.../application/components/sidebar/discover_field.tsx	50.00%	0 Missing and 1 partial ⚠️
...ation/components/sidebar/discover_field_bucket.tsx	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              2.x    #7366      +/-   ##
==========================================
+ Coverage   67.86%   67.90%   +0.04%     
==========================================
  Files        3600     3600              
  Lines       72615    72619       +4     
  Branches    11902    11902              
==========================================
+ Hits        49278    49311      +33     
+ Misses      20338    20300      -38     
- Partials     2999     3008       +9

Flag	Coverage Δ
Linux_1	`32.95% <20.00%> (+<0.01%)`	⬆️
Linux_2	`55.70% <75.00%> (+0.04%)`	⬆️
Linux_3	`43.71% <50.00%> (+0.05%)`	⬆️
Linux_4	`34.46% <0.00%> (ø)`
Windows_1	`32.97% <20.00%> (+<0.01%)`	⬆️
Windows_2	`55.65% <75.00%> (+0.04%)`	⬆️
Windows_3	`43.72% <50.00%> (+0.05%)`	⬆️
Windows_4	`34.46% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zhongnansu

can you fix the sanpshot failure in CI?

virajsanghvi

Did header_user_theme_menu.tsx go away?

src/plugins/data/public/ui/filter_bar/filter_options.tsx

src/plugins/data/public/ui/saved_query_management/saved_query_management_component.tsx

src/plugins/discover/public/application/components/sidebar/discover_field_bucket.tsx

virajsanghvi

This looks good given differences are because other changes aren't in 2.x, but we should validate the missing file doesn't intend to get to 2.x and that the miki's changes will still get picked up when backported. May make sense to hold off for those changes if they're coming soon.

ananzh · 2024-07-23T16:33:16Z

Should we hold and merge this after Miki's PR?

github-actions · 2024-07-23T16:54:41Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

github-actions · 2024-07-23T16:55:18Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

github-actions · 2024-07-23T16:57:08Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

github-actions · 2024-07-23T16:57:17Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

github-actions · 2024-07-23T17:11:08Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

zhongnansu · 2024-07-24T16:51:43Z

@danieldong51 could you check and resolve the conflicting files?

github-actions · 2024-07-24T18:15:53Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Dan Dong <danieldong51@gmail.com>

danieldong51 · 2024-07-24T23:22:44Z

ciGroup3 failing does not look related to my changes, rather due to EuiTextArea being changed to EuiCompressedTextArea in src/plugins/data_source_management/public/components/direct_query_data_sources_components/direct_query_data_source_configuration/prometheus/configure_prometheus_data_source.tsx

…h OUI tooltip (#7366) * Fixed merge conflicts Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated snapshot testing Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated snapshot testing Signed-off-by: Dan Dong <danieldong51@gmail.com> --------- Signed-off-by: Dan Dong <danieldong51@gmail.com> (cherry picked from commit 0b6ca1c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

github-actions bot added the failed changeset label Jul 22, 2024

danieldong51 force-pushed the backport/backport-7231-to-2.x branch from 0ae488a to 331bd56 Compare July 22, 2024 20:43

danieldong51 marked this pull request as ready for review July 22, 2024 22:00

zhongnansu reviewed Jul 22, 2024

View reviewed changes

zhongnansu added the v2.16.0 label Jul 23, 2024

danieldong51 requested a review from zhongnansu July 23, 2024 03:18

virajsanghvi reviewed Jul 23, 2024

View reviewed changes

virajsanghvi previously approved these changes Jul 23, 2024

View reviewed changes

virajsanghvi added the backport 2.16 label Jul 23, 2024

ananzh previously approved these changes Jul 23, 2024

View reviewed changes

This was referenced Jul 24, 2024

[Backport 2.x] [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. #7438

Merged

[Backport 2.16] [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. #7439

Closed

danieldong51 dismissed stale reviews from ananzh and virajsanghvi via 2e1c330 July 24, 2024 18:12

danieldong51 force-pushed the backport/backport-7231-to-2.x branch from 4f4715a to 2e1c330 Compare July 24, 2024 18:12

danieldong51 force-pushed the backport/backport-7231-to-2.x branch from 2e1c330 to 33d3676 Compare July 24, 2024 20:23

danieldong51 added 2 commits July 24, 2024 14:49

Fixed merge conflicts

2075137

Signed-off-by: Dan Dong <danieldong51@gmail.com>

Updated snapshot testing

b76a897

Signed-off-by: Dan Dong <danieldong51@gmail.com>

danieldong51 force-pushed the backport/backport-7231-to-2.x branch from 33d3676 to b76a897 Compare July 24, 2024 21:50

danieldong51 requested a review from sejli as a code owner July 24, 2024 21:50

Updated snapshot testing

71baf86

Signed-off-by: Dan Dong <danieldong51@gmail.com>

LDrago27 approved these changes Jul 25, 2024

View reviewed changes

ananzh approved these changes Jul 25, 2024

View reviewed changes

ananzh merged commit 0b6ca1c into opensearch-project:2.x Jul 25, 2024
65 checks passed

opensearch-trigger-bot bot mentioned this pull request Jul 25, 2024

[Backport 2.16] [Manual] [Backport 2.x] [Look&Feel] Replace browser tooltip usage with OUI tooltip #7474

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Manual] [Backport 2.x] [Look&Feel] Replace browser tooltip usage with OUI tooltip #7366

[Manual] [Backport 2.x] [Look&Feel] Replace browser tooltip usage with OUI tooltip #7366

danieldong51 commented Jul 22, 2024 •

edited

Loading

github-actions bot commented Jul 22, 2024

codecov bot commented Jul 22, 2024 •

edited

Loading

zhongnansu left a comment

virajsanghvi left a comment

virajsanghvi left a comment

ananzh commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

zhongnansu commented Jul 24, 2024

github-actions bot commented Jul 24, 2024

danieldong51 commented Jul 24, 2024

[Manual] [Backport 2.x] [Look&Feel] Replace browser tooltip usage with OUI tooltip #7366

[Manual] [Backport 2.x] [Look&Feel] Replace browser tooltip usage with OUI tooltip #7366

Conversation

danieldong51 commented Jul 22, 2024 • edited Loading

Description

Changelog

Check List

github-actions bot commented Jul 22, 2024

❌ Empty Changelog Section

codecov bot commented Jul 22, 2024 • edited Loading

Codecov Report

zhongnansu left a comment

Choose a reason for hiding this comment

virajsanghvi left a comment

Choose a reason for hiding this comment

virajsanghvi left a comment

Choose a reason for hiding this comment

ananzh commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

❌ Empty Changelog Section

github-actions bot commented Jul 23, 2024

❌ Empty Changelog Section

github-actions bot commented Jul 23, 2024

❌ Empty Changelog Section

github-actions bot commented Jul 23, 2024

❌ Empty Changelog Section

github-actions bot commented Jul 23, 2024

❌ Empty Changelog Section

zhongnansu commented Jul 24, 2024

github-actions bot commented Jul 24, 2024

❌ Empty Changelog Section

danieldong51 commented Jul 24, 2024

danieldong51 commented Jul 22, 2024 •

edited

Loading

codecov bot commented Jul 22, 2024 •

edited

Loading