Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.16] [Backport 2.x] Add Drag & Drop Across Axis Functionality to Vis Builder #7416

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b1e5237 from #7266.

* Add Drag Across Axis Functionality to Vis Builder

* Changeset file for PR #7107 created/updated

---------

(cherry picked from commit 27669cf)

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b1e5237)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 10.55901% with 144 lines in your changes missing coverage. Please review.

Project coverage is 67.71%. Comparing base (8f36039) to head (ca65208).

Files Patch % Lines
...r/public/application/components/data_tab/index.tsx 0.00% 39 Missing ⚠️
...ta_tab/drag_drop/replace_field_in_configuration.ts 0.00% 23 Missing ⚠️
...s/data_tab/drag_drop/move_field_between_schemas.ts 0.00% 18 Missing ⚠️
...mponents/data_tab/utils/get_valid_aggregations.tsx 21.73% 18 Missing ⚠️
...s/data_tab/drag_drop/add_field_to_configuration.ts 0.00% 13 Missing ⚠️
...data_tab/drag_drop/reorder_fields_within_schema.ts 0.00% 11 Missing ⚠️
...pplication/components/data_tab/use/use_dropbox.tsx 0.00% 11 Missing ⚠️
...public/application/components/data_tab/dropbox.tsx 0.00% 9 Missing ⚠️
...c/application/components/data_tab/config_panel.tsx 0.00% 1 Missing ⚠️
...lication/components/data_tab/schema_to_dropbox.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.16    #7416      +/-   ##
==========================================
- Coverage   67.80%   67.71%   -0.10%     
==========================================
  Files        3578     3584       +6     
  Lines       72123    72240     +117     
  Branches    11788    11818      +30     
==========================================
+ Hits        48905    48915      +10     
- Misses      20246    20354     +108     
+ Partials     2972     2971       -1     
Flag Coverage Δ
Linux_1 33.18% <10.55%> (-0.07%) ⬇️
Linux_2 55.66% <ø> (ø)
Linux_3 44.47% <ø> (+0.01%) ⬆️
Linux_4 34.20% <ø> (ø)
Windows_1 33.20% <10.55%> (-0.07%) ⬇️
Windows_2 55.61% <ø> (ø)
Windows_3 44.47% <ø> (ø)
Windows_4 34.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving assuming failed checks are unrelated

@ananzh ananzh merged commit 3505cca into 2.16 Jul 24, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset v2.16.0 valued-contributor vis builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants